U4-11472 - Create a Document Type folder with an Ampersand

Created by Chris Houston 21 Jun 2018, 18:12:48 Updated by Sebastiaan Janssen 31 Jul 2018, 20:00:30

Tags: Up For Grabs PR

What did you do?

Using Umbraco 7.11 I tried to create a document type folder named: News & Event Pages

What did you expect to happen?

That the folder would be created with the above name.

What actually happened?

The folder was created named: News

Comments

Sebastiaan Janssen 11 Jul 2018, 06:28:06

I've marked as "Up for grabs" so that you or someone else coming along could create a pull request for it.


Chris Houston 31 Jul 2018, 14:59:01

Actually after a bit of further investigation, this actually effects:

  • Document Type Folders
  • Media Type Folders
  • Data Type Folders Pull request is on it's way...


Chris Houston 31 Jul 2018, 15:08:34

@sebastiaan I have just submitted a pull request that fixes these issues: https://github.com/umbraco/Umbraco-CMS/pull/2825

I noticed as well that Data, Document & Media Types also don't allow Ampersands ( Or probably any special character ) is this by design? If not, I can see it would be a pretty easy fix in another pull request.

As well as allowing them to be saved, it would also involve ensuring those characters are filtered out of the Alias that is automatically created.

E.g. Fish & Chips => fishChips ( currently it creates: "fish" and then fails to save )

Cheers, Chris


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.11.0

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: