U4-11473 - Member login does not check for unique on edit

Created by Tim Zander 21 Jun 2018, 21:27:27 Updated by Jeff Lewis 19 Jul 2018, 16:40:39

Tags: Up For Grabs

When I create a new member it enforces a unique login name, but it I edit an existing member to have the same login/username it saves without problem.

See U4-2796 however I am experiencing this issue in 7.10.4

Comments

Sebastiaan Janssen 11 Jul 2018, 06:28:31

I've marked as "Up for grabs" so that you or someone else coming along could create a pull request for it.


Jeff Lewis 19 Jul 2018, 16:40:39

@sebastiaan I've started taking a look at this. I have a fix, but it is in Umbraco.Web.Editors.MemberController. Per Shannon's comments in the referenced issue that saving (or not) should be handled in the membership provider, I'm guessing this isn't the desired way to handle it. However, I'm not seeing an obvious location in Umbraco.Web.Security.Providers.MembersMembershipProvider where it should be handled instead.

There is an UpdateUser method in the provider which could be overridden and a check added, but the comment specifies that it 'Updates e-mail approved status, lock status and comment on a user.' So it doesn't seem like the right place either.

Do you have any input on this?


Priority: Normal

Type: Bug

State: Open

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.10.4

Due in version:

Sprint:

Story Points:

Cycle: