U4-11495 - Add border to custom regex in property settings

Created by Niels Lyngsø 02 Jul 2018, 13:58:29 Updated by Niels Lyngsø 16 Jul 2018, 09:15:57

Tags: Up For Grabs PR

Please add a border around the custom validation input, see attached mockup.

1 Attachments

Comments

Sebastiaan Janssen 10 Jul 2018, 09:14:34

That looks much nicer indeed @nielslyngsoe - care to submit a PR for this? I've put it in Up for grabs so that you or someone else can pick this up.


Jan Skovgaard 15 Jul 2018, 10:26:06

I have done a PR here: https://github.com/umbraco/Umbraco-CMS/pull/2772


Niels Lyngsø 16 Jul 2018, 09:15:57

@JanSkovgaard Thanks, good job.

I´m not up to speed with Pull Requests jet, but I will come by HQ in late august and plan on getting at short introduction so I can get started.


Priority: Normal

Type: Cosmetics

State: Fixed

Assignee:

Difficulty:

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions:

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: