U4-11497 - Make JSON storage default on the Tags property editor

Created by Jan Skovgaard 03 Jul 2018, 18:09:55 Updated by Sebastiaan Janssen 25 Jul 2018, 09:10:00

Tags: Up For Grabs PR

Ever since Umbraco 7.6 was released it came with property value converters built in. So when using the Tags property editor there is no longer a reason for having the option to save the tags as CSV or JSON - No matter what one choose the tags are returned in the same way so the code needed to iterate the collection returned is the same.

The only difference between the options is that with JSON it's possible to save comma seperated strings so it's possible to have a tag like "Umbraco, CMS, Community", which is of course not possible with CSV.

Therfore I suggest that JSON is being set as the default storage option out of the box and that CSV is being kept for legacy reasons, in case of upgrades from older Umbraco versions, and is marked as obsolete in the dropdown,

And in v8 I suggest the CSV option is removed alltogether - See http://issues.umbraco.org/issue/U4-11496

Comments

Sebastiaan Janssen 10 Jul 2018, 09:20:34

Agreed, it should be the default option for any newly created tags property editors. Care to submit a PR?


Jan Skovgaard 10 Jul 2018, 09:53:22

Yup I will be happy to look into this and see if I can manage to fix it. But don't know if it will be this week, during the weekend or next week. So if anyone beats me to it that's fine :)


Jan Skovgaard 15 Jul 2018, 11:19:52

No one beat me to it so here is the PR: https://github.com/umbraco/Umbraco-CMS/pull/2773 :-)


Priority: Normal

Type: Feature (request)

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions:

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: