U4-11517 - E-mail property editor triggers validation when validation has not been enabled in the settings

Created by Jan Skovgaard 14 Jul 2018, 17:00:11 Updated by Sebastiaan Janssen 15 Jul 2018, 06:35:07

What did you do?

I created an e-mail datatype based on the "E-mail" property editor. I did not change the "Required" setting.

What did you expect to happen? That I was able to save my document type without having to enter a value in the e-mail field.

What actually happened? Validation was triggered and I had to enter a valid e-mail address before I could save the document type.

Also isn't it a bit weird to have the required setting here? I mean it would make more sense to have it use the same logic as all the other fields on a document type where the "Field is mandatory" can be checked when adding a datatype to it?

I think that if the e-mail property editor should have any settings it should perhaps be a regex pattern, which can be used to determine the allowed format for the e-mail address? But that's also a thing that can be done in the validation settings for the datatype when adding it to the document type...So perhaps this property editor should maybe be marked as obsolete in v7 and removed in v8...or? :-)

2 Attachments

Comments

Sebastiaan Janssen 15 Jul 2018, 06:34:54

Fixed in https://github.com/umbraco/Umbraco-CMS/commit/24e9136f578335f5f98d73d05915528d86a0c84b

You can either check mandatory or required, OR both! ;-)

No, people should stop coming up with email regexes, they are all broken (most of them don't validate test@test.pizza). As far as I know, the C# email validator that is used is following the exact RFC for email address formats and seems to work just fine on this field.

I think it's fine to keep this editor. If you need an editor with a custom regex, use a textbox ;-)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.11.1

Due in version: 7.12.0

Sprint:

Story Points:

Cycle: