We have moved to GitHub Issues
Created by Niels Lyngsø 17 Jul 2018, 07:45:55 Updated by Niels Lyngsø 03 Aug 2018, 12:18:51Tags: Up For Grabs
The feature "Send for approval" is great, but is mostly worded "Send to publish", which I find a little confusing and potentially will confuse users of the system, especially when subscribing for notifications.
The wording exposed to the editors are "Save and send for approval", there for I think the feature should be worded "Send for approval" everywhere. By this I mean, in User-Group-Settings, and in the Notifications-Subscribing. (where it today is worded "Send to publish")
I've marked as "Up for grabs" so that you or someone else coming along could create a pull request for it.
It would be interesting to see how many localisation changes for this are also required.
I see that localization key are like this:
Does the alias need to be changed as well?
The alias should not be changed. Because this is what is used to get the translation.
How many places should this be corrected? I'm having a look now and until now from what I can tell it happens in the context menu when an editor right clicks. It says "Send to Publish" instead of "Send for approval".
And when setting default permissions on a user group. See the attached screendumps. Are there anymore places you can think of? :)
Super great. I can say it also appears in the Action menu, that appears top right corner when editing a node, but I really hope the options appearing here is the same as the ones in the context menu. (I have added a screenshot of it)
Otherwise I cant think of anywhere else. Wouldn't it be possible to search the code for it? — Just asking cause I haven't reached the level where I have Cloned Umbraco or made Pull-Requests myself, but I will soon get at it. But just to be sure we cover all possibilities. :-)
Backwards Compatible: True
Due in version: