We have moved to GitHub Issues
Created by Jan Skovgaard 28 Jul 2018, 11:28:21 Updated by Sebastiaan Janssen 01 Aug 2018, 07:58:22Tags: PR
Subtask of: U4-11510
So when I looked at this PR https://github.com/umbraco/Umbraco-CMS/pull/2792 for the color picker in the document editor I thought that it would be nice to display the active state on the "Approved color picker" datatype in the same fashion instead of using that dashed border. The dashed border does not look too good whenever labels are active and using the "checkmark" icon like when selecting the color for the backoffice icons aligns the visuals etc. :-)
I like it!
Can't see from the picture if the checkmark is outlined, but I think it should be; otherwise we have to have a dark version too and provide logic to decide which one to use, depending on the underlying color. If the icon is outlined with a dark color, it'll be visible even on very bright backgrounds.
@greystate Yeah I realise I should have used a better color example to illustrate it. But it has a outline like you see in this screendump by Owain on his first PR for the color picker on the document type here https://github.com/umbraco/Umbraco-CMS/pull/2555#issuecomment-387024919
It's the same markup and styling that is being used for the color picker datatype with this PR :)
The background color in the circle is set to 0.15% black so it works on top of a pure white color too.
@JanSkovgaard Yes, of course - perfect :)
Fixed with PR: https://github.com/umbraco/Umbraco-CMS/pull/2816
Backwards Compatible: True
Fix Submitted: Pull request
Due in version: 7.12.0