U4-11555 - V8 - Remove App_Browsers folder

Created by Lee Kelleher 06 Aug 2018, 09:00:05 Updated by Lee Kelleher 08 Aug 2018, 10:53:49

Tags: Up For Grabs

Subtask of: U4-8226

I believe the '''App_Browsers''' folder can be removed for v8

ASP.NET uses the App_Browsers folder to store specific browser capabilities, and mostly for WebForms.

With Umbraco we have the following config files...

=== Form.browser ===

The contents of Form.browser is a single <controlAdapters> entry, which is used to adapt the "action" attribute of the HtmlForm control.

https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web/umbraco.presentation/umbraco/urlRewriter/UrlRewriterFormWriter.cs#L37-L63

The code checks for a couple of Context.Items, namely "VirtualUrl" and ORIGINAL_URL_CXT_KEY constant (which is "umbOriginalUrl")

Searching the codebase, they are only being referenced in the following places...

As far as I can see, requestModule is no longer being used. But LegacyRequestInitializer is being called by UmbracoModule...

https://github.com/umbraco/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web/UmbracoModule.cs#L58-L61

...so I'm not sure if this is still required for v8 or not? I guess the question is, '''is WebForms still being used in the v8 back-office?'''

=== w3cvalidator.browser ===

This is being used for one specific thing only...

ASP.NET 2.0 has problems when trying to validate a XHTML 1.0 Strict page using the W3 validation service.

See this page for further details... http://wiki.lessthandot.com/index.php/ASP.NET:_XHTML_Strict_Validation

I'm not sure if this was resolved in subsequent versions of ASP.NET, or even if it's still relevant, (given the popularity of HTML5 over XHTML Strict)?

Comments

Sebastiaan Janssen 06 Aug 2018, 09:51:24

The Form one.. don't know, maybe that was only for frontend? We won't support WebForms templates for frontend any more and hopefully we'll remove all webforms from the backoffice as well.

The XHTML one I don't think we need to worry about any more. :)


Lee Kelleher 08 Aug 2018, 10:53:49

PR submitted: https://github.com/umbraco/Umbraco-CMS/pull/2842

I looked over where WebForms is still used in the back-office, most bits have been marked as to be rewritten in AngularJs. I couldn't find anything that was broken due to removing the Form.browser (and associated code).


Priority: Normal

Type: Task

State: Open

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 8.0.0

Due in version: 8.0.0

Sprint:

Story Points:

Cycle: