U4-11580 - Database health check should not report on custom tables that are not part of Umbraco's schema

Created by Sebastiaan Janssen 16 Aug 2018, 08:44:00 Updated by Sebastiaan Janssen 16 Aug 2018, 11:00:04

Relates to: U4-9544

See: https://our.umbraco.com/forum/using-umbraco-and-getting-started/93290-health-check-database-schema-validation-error

Comments

Nik 16 Aug 2018, 08:49:52

Just a thought, it could be helpful if the health check reported something like: "x number of custom tables were found in the database, these are not verified as part of the health check"

This would just remind people if there are custom tables, rather than completely ignoring them :-)


Sebastiaan Janssen 16 Aug 2018, 08:52:14

What would the purpose be of reminding them? I don't really see the point. Besides it will still confuse more people who didn't originally install the site. "Oh, there's custom tables, I don't know what they're for, I'll just remove them." :-)


Nik 16 Aug 2018, 09:09:54

The thought rose from the health check being logged as this "DatabaseSchemaValidationHealthCheck", if it's not processing the entire schema and reporting on it completely, maybe the name needs to change then? So it's clear that it is only validating and reporting on the core Umbraco schema components?

It may well confuse people that custom tables exist. I guess I imagined HealthChecks are targeted more at developers who I'd expect not to just delete custom tables because they don't know what they are for (yep it's an assumption), and informing them they exist would be more beneficial than not. Without looking into the database there isn't a way to know that they do exist, and if there was only 1 or 2 they could easily be missed if you did take the time to look at the database, depending on how they were named.

Another thought, it would be cool if package developers (or general developers) could add additional checks into the Database Health Check to allow it to validate custom tables to help it become more complete, without having to create their own Health Check. (I've not looked into this so it may already be possible).


Sebastiaan Janssen 16 Aug 2018, 11:00:04

@Nik For the built-in health checks we should not consider custom things really, we don't control it and it will be very difficult to provide anything for them that makes any sense.

I think this discussion might stem from the fact that you didn't know custom health checks can be built? It's super cool! https://our.umbraco.com/Documentation/Extending/Healthcheck/

You can target any existing category as well, check away.


Priority: Normal

Type: Bug

State: Open

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.12.0

Due in version:

Sprint:

Story Points:

Cycle: