Click here to create a new issue on GitHub

U4-11601 - v7.11.1 "PublishAt/UnPublishAt" on Info tab ignores workflow status

Created by Tom Daria 24 Aug 2018, 11:41:43 Updated by Sebastiaan Janssen 05 Sep 2018, 14:57:04

This issue continues on GitHub, click to go to the new issue

Relates to: U4-10773

There are two use cases which produce the same result. With Umbraco 7.11.1 there is a new tab called "Info". This tab is allows editors/approvers/publishers/Administrators to set "publish/unpublish" date/time. However, in either case, when the "publish/unpublish" is set, the Umbraco background scheduling will "auto" publish/unpublish the content at the specified date and time. In other words, it ignores approval process altogether. Imagine the case where you set unpublish date (i.e. 10 minutes from now), click the "save and schedule" command button followed by the "Save and Send for Approval" button. Now the approver is away from the office and can't approve the change. However, the Umbraco background scheduler fires every minute and after 10 minutes will pick up the change remove the page from the site, disregarding approval process.

The scheduler code should take into account that the page is waiting for approval and NOT auto remove the page until the change has been approved and published.

Thanks

Tom Daria

Comments

Sebastiaan Janssen 27 Aug 2018, 05:04:03

Thanks Tom, I can reproduce. The logic for this is a little tricky so I will need to talk to the team and see what we can do. I think it would make the most sense to not show the panel to schedule publish/unpublish to people who don't have publish permissions, what do you think?
Tom Daria 27 Aug 2018, 10:23:55

Dear Sebastiann: Thanks for replying. And glad you could reporduce. Here is my two cents.
Changing the page status from either published or Unpublished should be INITIATED by content editors. In my opinion, it is a content change. So for this reason I vote to keep the date controls available for the editors.
I think what needs to be done is to add an additional check to see if the page is still in some workflow state (submitted, waiting for approval, rejected). So if the page is in "waiting approval" state, the scheduling engine which runs every minute, would check for this and if the page/content/media is in a waiting for approval state, it should not auto-publish!

Make sense?
Tom Daria 30 Aug 2018, 10:20:37

Dear Sebastiann:

Good mornning.

Can you give me an update? Do you need more information? Let me know. Thanks

Tom
Sebastiaan Janssen 04 Sep 2018, 12:39:01

Hi @TomDaria - we've discussed this internally, apologies for the wait.

  1. We do realize that letting people set a publish date while they don't have publish rights is a bug and we will fix that issue
  2. Your workflow requirements are quite specific to your current project(s) and we don't have feature in Umbraco to support them. As alternatives we would recommend you look into adding a datepicker named "suggested publishdate" and using an eventhandler once someone with publishing rights approves the content to copy the suggested date over to the content's scheduled publishing date. If you need help with this, you could head over to our forum (https://our.umbraco.com) to discuss how you would implement such a thing.
Sebastiaan Janssen 05 Sep 2018, 14:55:46

FYI: we're almost done completing the move to the new issue tracker as announced here: https://umbraco.com/blog/a-new-take-on-the-umbraco-issue-tracker/

I am closing the issue here on the old issue tracker, but it will continue on the new issue tracker. The new link is: https://github.com/umbraco/Umbraco-CMS/issues/2919
Sebastiaan Janssen 05 Sep 2018, 14:57:04

FYI: we're almost done completing the move to the new issue tracker as announced here: https://umbraco.com/blog/a-new-take-on-the-umbraco-issue-tracker/

I am closing the issue here on the old issue tracker, but it will continue on the new issue tracker. The new link is: https://github.com/umbraco/Umbraco-CMS/issues/2920

Priority: Normal

Type: Bug

State: Closed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version:

Sprint:

Story Points:

Cycle: