U4-1285 - Apostrophes in Member Groups causes exception

Created by Kevin Lawrence 29 Nov 2012, 15:34:19 Updated by Sebastiaan Janssen 19 Jul 2013, 12:43:57

Creating a member group that contains an apostrophe such as '''Kev's Member Group''' causes exception to be thrown here:

umbraco.presentation.members.EditMemberGroup.Page_Load(Object sender, EventArgs e) in \umbraco_09f5a69cf19e\src\Umbraco.Web\umbraco.presentation\umbraco\members\EditMemberGroup.aspx.cs:55

Comments

Andy Butland 25 Jun 2013, 20:20:25

I've supplied a [https://github.com/umbraco/Umbraco-CMS/pull/31 pull request] to fix this issue (and a couple of related ones where similar issues prevented renames and deletes).


Michiel van Oosterhout 03 Jul 2013, 15:54:52

Cannot repro in 6.06


Andy Butland 18 Jul 2013, 14:17:18

I think this is still an issue - tried with the latest code in 6.1.3 and get an error as originally reported. Note it's not on the create, but when you subsequently click to edit it from the node tree. Deleting doesn't work either (no error, just fails). As such have taken the liberty of removing the "Can't reproduce" tag.


Sebastiaan Janssen 18 Jul 2013, 15:35:46

@Andy I don't get the error and I can delete the member group just fine. What am I doing wrong?

  • Right-click > Create > Name: Kev's Member Group > Create
  • I get member type editor, no errors
  • Changing name to Kev's Member Group2 works, no errors
  • Changing name to SomethingElse works, no errors
  • Changed back to Kev's Member Group, no errors
  • Right click the member group and Delete, no errors


Andy Butland 18 Jul 2013, 15:51:06

Here's what I'm seeing Seb: http://www.screenr.com/mpWH


Sebastiaan Janssen 18 Jul 2013, 15:55:10

D'oh!!! Member GROUPS.. I was doing all this on member types. :)


Sebastiaan Janssen 18 Jul 2013, 15:57:03

Do you still have that pull request open somewhere? The oine you linked to is closed.


Andy Butland 18 Jul 2013, 15:59:05

Yes, it's here: https://github.com/umbraco/Umbraco-CMS/pull/32


Sebastiaan Janssen 19 Jul 2013, 12:43:49

Thanks Andy!

Pull request accepted and merged into 6.1.3. Rev: 972b903f5273a89834297ad2ecde08c15c8dbeb4


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Very Easy

Category: UI

Backwards Compatible: False

Fix Submitted: Pull request

Affected versions: 4.9.0

Due in version: 6.1.3

Sprint:

Story Points:

Cycle: