U4-1468 - Change document type on node UI

Created by Jeroen Breuer 14 Jan 2013, 21:22:36 Updated by Sebastiaan Janssen 19 Mar 2014, 12:27:02

Relates to: U4-79

With the new API it's possible to change the document type of a node, but there is no UI to do this. Probably something which can be done when the new "Belle" UX is added.

2 Attachments

Comments

Sebastiaan Janssen 14 Jan 2013, 21:26:14

There is not v7.0.0 so it cannot be the affected version.


Andy Butland 13 Feb 2013, 19:01:18

I've provided a [http://umbraco.codeplex.com/SourceControl/network/forks/abutland/WorkingFork/contribution/4076 pull request] for this. Please also see [https://groups.google.com/forum/?hl=en&fromgroups=#!topic/umbraco-dev/30yY0Qt4jbI discussion on the mailing list]. Hope it proves useful.


Morten Christensen 14 Feb 2013, 11:03:51

Thanks Andy! I hope to have time to review it next week.


Jeroen Breuer 28 Feb 2013, 16:26:26

Is there a chance the pull request will be added to 6.1?


Morten Christensen 01 Mar 2013, 08:39:49

That is what we are aiming for, so yes.


Jeroen Breuer 10 Apr 2013, 16:11:11

This issue isn't closed yet. Does this mean it's not in the beta (sorry didn't test it yet)?


Morten Christensen 10 Apr 2013, 16:14:34

Ehm .. Good question. I was actually supposed to review it, but never found the time. Sebastiaan did however review it, but not sure if he expected me to have a look before adding the pull request. Sebastiaan?


Jeroen Breuer 23 May 2013, 12:02:37

Didn't have time to check 6.1 beta 2 yet, but I assume it's also not in there?


Funka! 26 Jul 2013, 22:10:51

Have there been any updates on this? I saw a month ago in the google dev group that there was some disucssion and request for comments/evaluation on Andy's pull request from last February, ... but then everything went quiet and no follow-up since then. Is there a chance of maybe seeing this in 6.2.0 next month? Thank you!


Sebastiaan Janssen 27 Jul 2013, 09:01:20

6.2.0 is 2 months away.. ;-) And yes we're definitely looking into adding it to that version.


Sebastiaan Janssen 25 Aug 2013, 15:17:21

Pull request accepted, revisions: 76d0ffb7974841341ef7cd8d6c4e12605f33b274 and d21f10ec1e6a952d4c10c2dd3775245600c42800


Martin Griffiths 03 Feb 2014, 10:49:05

Can someone say how soon/likely this feature will make it into v7?


Sebastiaan Janssen 20 Feb 2014, 09:50:06

This feature will also be available in v7.1.0.


Jeroen Breuer 20 Feb 2014, 10:04:47

Woohoo!!!


Dan Booth 20 Feb 2014, 19:26:30

Does this enable you to change the master doc type for a document?


Sebastiaan Janssen 20 Feb 2014, 19:47:38

@Dan.Booth It enables you to.. change the document type for a document.

So: when the document is currently of type "SpecialTextPage" you could change it to "VerySpecialTextPage". You'll get asked to map the existing properties to properties on the new document type and if that's all valid it will save and publish.


Dan Booth 20 Feb 2014, 19:53:48

Yeah, I gathered that, but wondered whether the same mechanism could also apply to changing which document the doctype inherited from. Clearly it doesn't so is there a separate issue for that request? I know it's something many people have wanted.


Sebastiaan Janssen 20 Feb 2014, 19:57:32

@Dan.Booth Sure, don't you remember? You created one.. ;-) http://issues.umbraco.org/issue/U4-259


Dan Booth 20 Feb 2014, 20:00:08

Hah, that was on the old tracker - glad it made it! Thanks :p


Douglas Robar 10 Mar 2014, 15:01:58

Had a look at this in 7.1.0 beta. Works nicely, thank you!!

However, the UI is confusing because everything is left-aligned and all of the same text size and spacing giving no sense of hierarchy and instruction (see attached screenshot in which 'Item 2' is the pagename).

Also, there should be a 'Select New Template' heading as there are 3 steps to be taken.


Jeroen Breuer 10 Mar 2014, 15:32:10

Hmm Douglas his screenshot looks different from mine. See attachment. Content and Current type are clickable, but nothing happens when I click them. The UI of the "Generic properties" tab at "Document Types" in "Settings" has been improved in this version. I think it should look more like that.

The attachment can be viewed at the top of this issue (called i4.jpg), but doesn't appear to be linked to this comment.


Douglas Robar 10 Mar 2014, 15:35:37

I think Jeroen, you don't have any other docTypes that are allowed at the root of the site. You can only change a docType to another one that is allowed at the same location in the content tree according to the note in the dialog box.

If there are no available docTypes to change to the dialog should say so and not display the other items. That would help avoid some confusion.


Jeroen Breuer 10 Mar 2014, 15:37:47

Ah Douglas you're probably right. I just clicked Change Document Type to see what would happen.


Douglas Robar 10 Mar 2014, 15:43:46

Lots of people will do the same and be equally confused. The UI needs some polish though the functionality is good.


Andy Butland 16 Mar 2014, 21:39:33

Just checked it on 7.1 beta too - agree the top panel in particular is a bit confusing now. It's been more than a year since the pull request so I guess other amends have affected it in the meantime, probably the v7 "wrapping" of user controls in an IFRAME.

I've tested the following CSS (on Chrome) which restores how the interface was intended to look. Though it needs someone more familiar with how the CSS for the dialogs is organised to apply, as possibly it could affect other things (or conversely be useful to apply more widely).

.umb-dialog .umb-control-group .umb-el-wrap { overflow: hidden; } .umb-dialog .umb-control-group .umb-el-wrap label { float: left; width: 140px; font-weight: bold; } .umb-dialog .umb-control-group .umb-el-wrap label:after { content:":"; } .umb-dialog .umb-control-group .umb-el-wrap .controls-row { float: left; width: 280px; padding-top: 8px; } .umb-dialog .umb-control-group .umb-el-wrap .controls-row select { width: auto; }


Douglas Robar 16 Mar 2014, 22:06:12

Thanks, Andy, that CSS helps a LOT, making it much clearer! The font sizes should be updated to match those of other panels, but the layout is super!

In addition to Andy's CSS I would recommend the following design love:

  1. Above the 'New Template:' line, add a header titled 'Select New Template' because this is a separate step and depends on first selecting the new document type.

  2. De-activate and gray-out the selection of a New Template until the new document type has been selected and is different than the current type.

  3. De-activate and gray-out the Property Mapping selection(s) until the new document type has been selected and is different than the current type.

  4. Update the explanatory text for each step to give more instruction and less repetition of the headings and labels in the rest of the panel, which currently makes them rather redundant instead of truly helpful.

  5. Add a note about what will happen to properties that map to dramatically different datatypes and any existing properties that aren't mapped to new properties to avoid complaints about people losing data?

cheers, doug.


Sebastiaan Janssen 19 Mar 2014, 12:27:02

@abutland Thanks! Updated the styling in inline css so it only affects this dialog.

@drobar Lots of good suggestions which will get lost in an issue that's closed. Add a feature request please? It's all not super easy to do as these texts live in translatable items.


Priority: Normal

Type: Feature (request)

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 6.0.0

Due in version: 7.1.0, 6.2.0

Sprint:

Story Points:

Cycle: