U4-1469 - FileSystemProviderManager should return the implemented IFileSystem even when using GetFileSystemProvider(string alias)

Created by Shannon Deminick 14 Jan 2013, 22:23:24 Updated by Shannon Deminick 15 May 2013, 00:20:07

Relates to: U4-1156

Currently if you call: GetFileSystemProvider(string alias) it will return an instance of the underlying provider set in config even if there is a strongly typed provider associated to that alias. For example, the MediaFileSystem is declared as: [FileSystemProvider("media")] public class MediaFileSystem : FileSystemWrapper

but when you call: GetFileSystemProvider("media") it will return the instance of the underlying file system in config (by default this is PhysicalFileSystem). The FileSystemProviderManager should detect that there is a strongly typed file system by this alias and return it, just like it is done with the GetFileSystemProvider

Comments

Shannon Deminick 15 May 2013, 00:20:07

I'm going to change this request and keep the current implementation. The only other way we could return the strongly typed file system by name would be to scan assemblies for types and we're already doing that too much. I'm going to just rename the GetFileSystemProvider(string) to GetBase


Priority: Normal

Type: Bug

State: Closed

Assignee: Shannon Deminick

Difficulty: Normal

Category: Architecture

Backwards Compatible: True

Fix Submitted:

Affected versions: 4.10.0, 4.11.0, 4.11.1, 4.11.2, 4.11.3

Due in version:

Sprint:

Story Points:

Cycle: