U4-1958 - PropertyEditorValueConverter's not working with recursive properties

Created by Matt Brailsford 19 Mar 2013, 14:05:39 Updated by Stephan 01 Nov 2013, 08:11:48

Relates to: U4-2129

I'm using the standard setup of having site wide properties on the homepage node and trying to use recursive properties to access them. If I use a basic recursive lookup without using a PropertyEditorValueConverter it works, however with it enabled it fails to run the converter and so doesn't return a value.

I believe the problem is within PublishedContentExtensions.GetPropertyValue (line 156ish) whereby it looks up the recursive property ok, but when looking up the PropertyEditorValueConverter to use, it assumes the datatype for the value is declared on the current node (which it's not) and so it fails to find the datatype to pass in to the PropertyEditorValueConverter. What it needs to do, is if it gets the property recursively, fetch the datatype from the node it found the property on instead.

Comments

Tom Fulton 18 Apr 2013, 20:51:25

Looks like this is related and could probably be fixed at the same time


Stephan 15 May 2013, 12:31:39

Currently working on that part of the code, will look into it. But... is it not a duplicate of U4-2129 which is solved?


Matt Brailsford 15 May 2013, 12:36:57

Seems to be. But I would just make sure the fix in 6.x was back ported to 4.x


Jeroen Breuer 27 May 2013, 19:04:44

I'm on a 6.0.5 site and it also doesn't work if I try this:@(Model.Content.GetPropertyValue("footerText", true, new HtmlString("")))Is HtmlString also a PropertyEditorValueConverter?

The following does work:@Html.Raw((Model.Content.GetPropertyValue("footerText", true, "")))


Stephan 28 May 2013, 06:28:05

@Jeroen: is "footerText" a text block or a RTE? There's a built-in converter from RTE to IHtmlString, but a text block (textstring, whatever) returns as a string. Ah, and I think there's no ''type converter'' from string to IHtmlString. Though I think there should be one. Will look into it.


Jeroen Breuer 28 May 2013, 07:15:59

The "footerText" is an RTE.


Jeroen Breuer 21 Jun 2013, 12:05:13

Is there any more info about this issue?


Stephan 21 Jun 2013, 12:21:57

Not yet... working hard on refactoring how converters work so I have a set of patches that I have not commited yet. Would like to have a "polished" thing to commit. Unless it becomes critical?


Jeroen Breuer 21 Jun 2013, 12:25:31

No it's not critical. There are some good workarounds so it can wait :-).


Stephan 11 Oct 2013, 13:59:23

Confirming this seems to be fixed in 6.2.0.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 4.11.5, 6.0.5

Due in version: 6.2.0

Sprint:

Story Points:

Cycle: