We have moved to GitHub Issues
Created by Shannon Deminick 03 Apr 2013, 02:03:57 Updated by Nicholas Westby 30 Jan 2016, 22:13:54
Relates to: U4-6063
Relates to: U4-7865
Currently the way that AsynchronousRollingFileAppender works is that we spawn a new thread to write whenenver we detect that the buffer is written to. We don't really need to have a separate dedicated thread for this and instead can do what we do with the Examine core and:
When running a performance profiler on Umbraco, the AppendLoggingEvents shows up as a hot spot since it is running in an infinite loop.
I've posted an issue on our that might be related to this: https://our.umbraco.org/forum/umbraco-7/using-umbraco-7/66920-investigating-memory-issue-reporting-that-finalizer-thread-blocked As I say there though, not clear if this is a real problem, or just something that triggers a false report of a concern in the analysis.
I've updated the default logging with 7.3 to use a newer async mechanism, you can see the commit here:
Of course the old logging format still works but we'll ship with the new logging format which is based on this project: https://github.com/cjbhaines/Log4Net.Async ... which is based on the original implementation of AsynchronousRollingFileAppender, but the new way uses ParallelForwardingAppender which uses a BlockingCollection to perform the logging which is much nicer.
Assignee: Shannon Deminick
Backwards Compatible: True
Due in version: 7.3.0