U4-2097 - Package import causes template tree to break

Created by Anthony 10 Apr 2013, 10:56:15 Updated by Stefan Bohlin 17 Apr 2013, 14:16:27

Missing templates in the tree, and duplicated tempaltes.

http://our.umbraco.org/projects/starter-kits/ublogsy/ublogsy-bugs/40004-Failed-to-install-uBlogsy-on-603

Everything is fine in v6.0.2.

4 Attachments

Download Bootstrap_Template_6.0.5.zip

Comments

Sebastiaan Janssen 10 Apr 2013, 15:49:54

Confirmed that this is an issue. Was thinking it might be because they didn't switch to Mvc mode, but it does the same in Mvc mode. I tested uBlogsy as well before the release, thought it was supposed to look like that, suppose not! :)

Other than that everything still seems to work, we just have to have a look at how the template inheritance is different now.


Dima Stefantsov 11 Apr 2013, 04:32:54

Added info to forum post: cause of the issue is duplicate uniqueID values in umbracoNode table.


Sebastiaan Janssen 11 Apr 2013, 12:23:00

Thanks for having a look, the unique ID was indeed not quite as unique as we hoped, this has been fixed in changeset 23c9163557d1 and will be available in 6.0.4 and 6.1.0 final.


Stefan Bohlin 16 Apr 2013, 08:27:03

I still see the Template tree breaking in the newest 6.0.4 nightly. If i have 4 different templates it duplicates one of them 4 times.


Sebastiaan Janssen 17 Apr 2013, 07:48:50

@Stefan Screenshot please? Did you check out the forum topic and looked in the umbracoNode table for duplicate unique Id's? If you already had the problem and then upgraded, that's not going to fix the problem magically, you'll need to change the Id's in the database manually, make sure to generate new unique Id's first (for example in visual studio go to Tools > Create GUID).


Stefan Bohlin 17 Apr 2013, 07:59:56

I installed a completely fresh version of UmbracoCms.6.0.4-build.16 I then installed a package containing 4 templates and document types which have worked in all the previous versions of v6. When i go to templates i get 4 duplicates of one of the templates in the package.


Sebastiaan Janssen 17 Apr 2013, 09:33:10

@Stefan Okay, thanks for the screenshot. Can you attach the document types so we can have a look please (you can set it to visible only to the HQ if there's sensitive data in them)?


Stefan Bohlin 17 Apr 2013, 09:36:57

Here's the package :)


Sebastiaan Janssen 17 Apr 2013, 11:39:58

Thanks for the package Stefan, unfortunately I can't reproduce your issue (see screenshot). One thing you should do is change your umbracoSettings.config and not use Webforms but Mvc. I didn't try what happens in Webforms mode but I imagine I'd get the same result.


Stefan Bohlin 17 Apr 2013, 11:54:41

It was just a quick mistake that I hadn't set it to Mvc. I did test it first with Mvc where it failed as well. I just tried once more as you suggested and I still get the error.... Do you have another version than me ?


Stefan Bohlin 17 Apr 2013, 12:04:04

Here's the log from installing the package:

2013-04-17 14:02:30,382 [26] INFO Umbraco.Core.PluginManager - [Thread 6] Completed resolution of types of umbraco.interfaces.ICacheRefresher, found 20 (took 3ms) 2013-04-17 14:02:30,645 [26] WARN Umbraco.Core.Services.PackagingService - [Thread 6] Packager: Error handling allowed templates. Template with alias 'Forside' could not be found. 2013-04-17 14:02:30,647 [26] WARN Umbraco.Core.Services.PackagingService - [Thread 6] Packager: Error handling default template. Default template with alias 'Forside' could not be found. 2013-04-17 14:02:30,655 [26] WARN Umbraco.Core.Services.PackagingService - [Thread 6] Packager: Error handling allowed templates. Template with alias 'FullWidth' could not be found. 2013-04-17 14:02:30,656 [26] WARN Umbraco.Core.Services.PackagingService - [Thread 6] Packager: Error handling default template. Default template with alias 'FullWidth' could not be found. 2013-04-17 14:02:30,895 [26] INFO Umbraco.Core.PluginManager - [Thread 6] Completed resolution of types of umbraco.interfaces.IDataType, found 35 (took 3ms) 2013-04-17 14:02:30,950 [26] INFO Umbraco.Core.PluginManager - [Thread 6] Completed resolution of types of umbraco.interfaces.IApplication, found 7 (took 3ms) 2013-04-17 14:02:30,955 [26] INFO Umbraco.Core.PluginManager - [Thread 6] Completed resolution of types of umbraco.interfaces.ITree, found 27 (took 3ms) 2013-04-17 14:02:30,960 [26] INFO umbraco.content - [Thread 16] Loading content from database... 2013-04-17 14:02:31,292 [26] INFO Umbraco.Core.PluginManager - [Thread 13] Completed resolution of types of umbraco.interfaces.ITree, found 36 (took 0ms) 2013-04-17 14:02:31,294 [26] INFO Umbraco.Core.PluginManager - [Thread 13] Completed resolution of types of umbraco.BusinessLogic.Actions.IActionHandler, found 1 (took 0ms) 2013-04-17 14:02:33,082 [26] INFO umbraco.BusinessLogic.Log - [Thread 15] Log scrubbed. Removed all items older than 2013-02-16 14:02:33 2013-04-17 14:02:33,083 [26] INFO Umbraco.Core.UmbracoApplicationBase - [Thread 15] Application shutdown. Reason: ConfigurationChange 2013-04-17 14:02:33,492 [28] INFO Umbraco.Core.CoreBootManager - [Thread 5] Umbraco application starting 2013-04-17 14:02:33,501 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Determining hash of code files on disk 2013-04-17 14:02:33,505 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Hash determined (took 3ms) 2013-04-17 14:02:33,574 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of umbraco.interfaces.IApplicationStartupHandler, found 16 (took 64ms) 2013-04-17 14:02:33,578 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of Umbraco.Core.PropertyEditors.IPropertyEditorValueConverter, found 0 (took 2ms) 2013-04-17 14:02:33,580 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of Umbraco.Web.Mvc.SurfaceController, found 0 (took 2ms) 2013-04-17 14:02:33,583 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of Umbraco.Web.WebApi.UmbracoApiController, found 2 (took 2ms) 2013-04-17 14:02:33,586 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of Umbraco.Core.Media.IThumbnailProvider, found 3 (took 2ms) 2013-04-17 14:02:33,588 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of Umbraco.Core.Media.IImageUrlProvider, found 1 (took 2ms) 2013-04-17 14:02:33,623 [28] INFO Umbraco.Core.CoreBootManager - [Thread 5] Umbraco application startup complete (took 130ms) 2013-04-17 14:02:33,635 [28] INFO Umbraco.Web.Search.ExamineEvents - [Thread 5] Initializing Examine and binding to business logic events 2013-04-17 14:02:33,744 [28] INFO Umbraco.Web.Search.ExamineEvents - [Thread 5] Adding examine event handlers for index providers: 3 2013-04-17 14:02:33,756 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of umbraco.interfaces.IApplication, found 7 (took 5ms) 2013-04-17 14:02:33,791 [28] INFO Umbraco.Core.PluginManager - [Thread 5] Completed resolution of types of umbraco.interfaces.ITree, found 27 (took 3ms) 2013-04-17 14:03:24,045 [28] INFO Umbraco.Core.PluginManager - [Thread 6] Completed resolution of types of umbraco.interfaces.ITree, found 36 (took 5ms) 2013-04-17 14:03:24,064 [28] INFO Umbraco.Core.PluginManager - [Thread 6] Completed resolution of types of umbraco.BusinessLogic.Actions.IActionHandler, found 1 (took 2ms)


Stefan Bohlin 17 Apr 2013, 12:06:41

Here's the umbracoNode entries: 1045 False -1 0 1 -1,1045 0 befda83f-9c7b-4131-972b-ff229d98b208 Two Columns 6fbde604-4178-42ce-a10b-8a2600a2f07d 17-04-2013 14:02:30 1046 False -1 0 1 -1,1046 1 23a1a13e-db03-4563-a84e-8040e2e98dba Two Columns 6fbde604-4178-42ce-a10b-8a2600a2f07d 17-04-2013 14:02:30 1047 False -1 0 1 -1,1047 2 5679eda3-c49c-46a6-9f9b-f34ccb15ce25 Two Columns 6fbde604-4178-42ce-a10b-8a2600a2f07d 17-04-2013 14:02:30 1048 False -1 0 1 -1,1048 3 2bb12a9f-2d1f-4ed2-aa15-d73fec58c61f Two Columns 6fbde604-4178-42ce-a10b-8a2600a2f07d 17-04-2013 14:02:30


Stefan Bohlin 17 Apr 2013, 12:07:45

It makes no sense to me...


Sebastiaan Janssen 17 Apr 2013, 14:14:39

@Stefan Okay, I think I found it, it worked on my local builds of Umbraco but not the ones from TeamCity, this was due to a foreach loop that was not properly scoping closures (http://devnet.jetbrains.com/thread/273042) and apparently this does lead to a different build in a different compiler (the one on the build server). This is now fixed and I can install your package just fine on this build: http://nightly.umbraco.org/umbraco%206.0.4/UmbracoCms.6.0.4-build.19.zip


Stefan Bohlin 17 Apr 2013, 14:16:27

Awesome! Was pulling my hair out ;) Thanks!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 6.0.3

Due in version: 6.0.4

Sprint:

Story Points:

Cycle: