U4-2449 - Change the default admin users lang to en-us

Created by Jan Skovgaard 02 Jul 2013, 19:08:36 Updated by Shannon Deminick 24 Aug 2017, 23:40:11

I think it would make sense to change the default language of the admin user from en-uk to en-us.

It's weird that the default admin user has another language setting than the default added language in the settings section, which is en-us.

When trying to use the nice feature of translating the backoffice UI (In document types) by using dictionary items it's really confusing that it's not working untill the language of the admin is changed as well.

Should be a minor fix, no? :)

Cheers!

Comments

Jan Skovgaard 21 Jun 2014, 21:34:08

So seems this is in progress...But I actually made a PR for this a couple of months ago? See https://github.com/umbraco/Umbraco-CMS/pull/318 - Says it's closed though?


Vincent Baaij 23 Jun 2014, 07:30:46

I think it gets set to en-GB in the PR ( CultureName = "en-GB" in the 'green' line)


Shannon Deminick 21 Aug 2017, 06:13:30

So the CreateUmbracoLanguageData sets the en-US language, however the default user is just 'en' which translates to en-GB. So really the CreateUmbracoUserData() should set the admin to be en-US since the US language is the default language pack.

I'll update.

Please respond if you don't agree with that :)


Shannon Deminick 21 Aug 2017, 06:14:56

PR: https://github.com/umbraco/Umbraco-CMS/pull/2139


Mads Rasmussen 21 Aug 2017, 15:01:49

@Shandem It looks good and it totally works but new users have "en-GB" (United Kingdom) as default language when created (Tested in Umbraco 7.7). So do we want to change this for new users or change this back?


Sebastiaan Janssen 24 Aug 2017, 19:04:37

@madsrasmussen Correct, it looks like we get the language when creating a user from the web.config, this is now also updated for both new installs and upgrades.


Shannon Deminick 24 Aug 2017, 23:39:55

awesome work team! I'll merge and close :)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions:

Due in version: 7.7.0

Sprint: Sprint 66

Story Points: 0.5

Cycle: