U4-2593 - Hide "Link to Document" on content nodes that don't have a template selected

Created by Funka! 06 Aug 2013, 17:51:42 Updated by Shannon Deminick 21 Jun 2017, 07:58:45

Relates to: U4-862

Relates to: U4-3631

Originally requested as part of U4-862. The point is, if you have a node without a template, the page will never render and always shows a 404, so let's not keep linking to 404 pages from the backend when we know they won't ever work.

Note, I do not want the path itself hidden---this is vital information---but rather, let's wrap it in a dimmed-out SPAN tag instead of making it a link.

See attached screenshot showing a mockup/idea of how I might envision this looking. A text hint was added to the "link to document" and also up by the template selector itself.

1 Attachments

Comments

Sebastiaan Janssen 06 Aug 2013, 20:33:21

Similarly to U4-2586 I am not entirely sure we should do this, what if you had set up some URL rewrites that take this and redirect you to a perfectly working page. Unfortunately Umbraco can't "detect" all URL rewriting without a serious performance hit (I also think that's why U4-862 was only implemented 50% ;-)). And yes, we could make this a config option, but really, do we need even more config options? I think not.

How about we keep it clickable but make it a different color and add a message like "This document has no template so the link above will most likely not show any content."?


Funka! 07 Aug 2013, 00:08:16

I think that sounds better than nothing at all, so can't really complain. Although I personally have yet to use Url Rewriting in a way that sends you from a node's generated Url to some other Url (usually it's the other way around), I can certainly see how this might be a breaking change for anyone who does do this---and could also foresee problems with MVC doc type hijacking I suppose.

So instead of a config file setting, how about a checkbox on the document type "don't generate preview links when no template selected" ? This would maintain backward compatibility since you'd have to specifically check this to get this new behavior. And... I would be checking this box quite a bit, since pretty much every site we've built for the last two dozen or so all have some kind of "data" node or "container document type" children that are never intended for display. (And invariably lead to a phone call from confused clients.) I even hacked some javascript into editContent.aspx once for a client that called us on three separate occasions over a period of several months to just remove the whole thing. Maybe I should make myself a package that does this, but figured I must not be the only one with this problem. Thank you for the consideration!


Shannon Deminick 21 Jun 2017, 07:58:46

Closing issue due to inactivity - see blog post for details https://umbraco.com/blog/issue-tracker-cleanup/


Priority: Normal

Type: Bug

State: Closed

Assignee:

Difficulty: Normal

Category: UI

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version:

Sprint:

Story Points:

Cycle: