U4-2796 - Possible to have duplicate Login Name (Member.LoginName) for Umbraco Members

Created by David Prothero 05 Sep 2013, 20:09:17 Updated by Shannon Deminick 19 Dec 2013, 01:06:13

The back office will allow you to edit an existing member and change the Login Name to be the same as another.

Steps to reproduce:

  1. Create a new Member with Login Name "dprothero"
  2. Attempt to create another new Member with the same Login Name of "dprothero"
    • It should report "Login Name already exists" <-- this is good!
  3. Create a new Member with Login Name of "dprothero2"
    • Now you have two Members: dprothero and dprothero2
  4. Edit the dprothero2 member and change the Login Name to "dprothero", Save
    • Now you have two Members, BOTH with Login Name "dprothero"

Comments

David Prothero 05 Sep 2013, 22:20:04

Submitted a pull request to fix: https://github.com/umbraco/Umbraco-CMS/pull/129


Shannon Deminick 19 Dec 2013, 00:57:45

Pretty sure this should also be taken care of at the membership provider level, i'll merge in your PR and investigate why this is not handled at the business logic level.


Shannon Deminick 19 Dec 2013, 01:06:11

Ah, it's not handled at the business logic end because in v6 we bypass the actual MembershipProvider when saving a member if using the UmbracoMembershipProvider.

In v7 this is different - all members saving/updating/etc... is done via the MembershipProvider first and then we simply update the member custom properties separately (the way it should be). With the new membership changes being done in 6.2 this might end up being corrected.

In the meantime, thanks for the PR, works great!


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category: UI

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 6.1.3

Due in version: 6.2.0

Sprint:

Story Points:

Cycle: