U4-2833 - Packages using DataEditorSetting install doesn't save alias/key

Created by Lee Kelleher 10 Sep 2013, 17:57:02 Updated by Shannon Deminick 18 Mar 2017, 05:57:07

This was a complex one to figure out, so please bear with me.

When a package has a DataType that uses the {{DataEditorSetting}} attributes is installed, the associated key (alias) for the PreValue is not saved to the database ('{{cmsDataTypePreValues}}' table).

An example being the Google Maps package. We use the {{DataEditorSetting}} attribute on our properties for the Prevalue Editor. When we create the package manifest (via the back-office) we are given the following XML:

{{ }}

The issue here is that the manifest data doesn't contain enough data to populate the {{DataEditorSettingsStorage}} (so the data-type can be used immediately on a doc-type).

So when the data is passed through to the {{umbraco.cms.businesslogic.datatype.DataTypeDefinition.Import}} method, the call to create the PreValues doesn't contain the key/alias name for the {{DataEditorSetting}}.

At present the only workaround is to tell users that once they've installed the package, they must go to the data-type's prevalue editor and hit save - then that will populate the correct prevalue data.

I hope this makes sense?

Comments

Lee Kelleher 07 Nov 2013, 14:35:02

Pull request submitted: https://github.com/umbraco/Umbraco-CMS/pull/205


Lee Kelleher 07 Nov 2013, 16:31:58

Seems that my pull request has a breaking change - looking into an alternative solution.


Sebastiaan Janssen 29 Dec 2013, 14:34:16

The solution that we want for this is detailed in the discussion on the pull request.


Priority: Normal

Type: Bug

State: In Progress

Assignee: Lee Kelleher

Difficulty: Easy

Category: Packages

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 4.8.0

Due in version:

Sprint:

Story Points:

Cycle: