We have moved to GitHub Issues
You are viewing the read-only archive of Umbraco's issue tracker. To create new issues, please head over to GitHub Issues.
Make sure to read the blog posts announcing the move for more information.
Created by Shannon Deminick 28 Oct 2013, 06:03:34 Updated by Shannon Deminick 29 Oct 2013, 05:02:10
Relates to: U4-3132
Subtask of: U4-2891
For whatever reason the search results/terms, etc.... are being blindly added to the navigation service UI object. Why this is done is beyond me, the search controller should handle what it needs to, not adding new global properties to some other object. The search controller should also encapsulate the searching and the results, currently that is not the case either.
There's also security concerns about returning ISearchResults because that will return ALL information for each item when the EntityService should only return MINIMAL information to the end user since we are not limiting security based on sections for people that have access to this service.
Then there's the searchService which is persisting data in it's singleton... why?? angular services shouldn't really be persisting data, they are global singletons. That means this service can't really be reused.
Currently for every content search result we're then making another request just to get it's Url!!
Search should also accept a lucene query
There's also security concerns about returning ISearchResults because that will return ALL information for each item when the EntityService should only return MINIMAL information to the end user since we are not limiting security based on sections for people that have access to this service.
We'll create a lucene overload later when we need it, for now it uses a raw lucene query internally to get better results for each type.
Priority: Normal
Type: Bug
State: Fixed
Assignee: Shannon Deminick
Difficulty: Normal
Category:
Backwards Compatible: True
Fix Submitted:
Affected versions:
Due in version: 7.0.0
Sprint:
Story Points:
Cycle: