We have moved to GitHub Issues
Created by Matt Brailsford 07 Nov 2013, 11:29:12 Updated by Sebastiaan Janssen 04 Feb 2016, 18:17:41
Is duplicated by: U4-6560
Relates to: U4-7863
Relates to: U4-7899
Before I gate flamed, I know the "best practise" is to use "Web Application" projects (Morten ;), but I often use "Web site" projects for simpler sites as it is much quicker / more flexible to work with. The problem is, the nuget install powerscript has a dependency on a "project path" (when it copies over the files you don't want to include in your project file) which web site projects don't have. If the powerscript is changed to find the path via the projects properties object, both types of projects can be supported.
Pull request here https://github.com/umbraco/Umbraco-CMS/pull/193
I had noticed this too. When I attempted to install Umbraco to a website with NuGet, it was doing weird things, like creating a second web.config a folder higher than the website (at the same level as the solution file).
Some notes on Nuget dubugging, the easiest way to debug paths is with this package: https://www.nuget.org/packages/NuGetPSVariables When you install it it will create log files containing all variable values (it will auto uninstall itself too).
Forgot to update this, but here is an up to date working pull request https://github.com/umbraco/Umbraco-CMS/pull/738
PR for review: https://github.com/umbraco/Umbraco-CMS/pull/1090
@matt - i didn't know about that PR you just mentioned, we'll need to review this one first and then see if your other changes are required. If you can provide any feedback on this one that'd be great too since you may know if we've missed something. By my tests this works with both webapps and websites.
Ok, so here's the changes done:
Sounds about right to me. The biggest thing has always been the file paths as they have historically used the "project" object within the ps1 scripts, which for a website project doesn't exist. My PR basically uses other means to gather the correct paths which works for both. The rest, while looking complex, is basically to do handle injecting targets, which had to be done by hand, rather than using a helper that was used previously.
PS I'll try and test the PR you reference if I have a spare minute
The PR will build in the next ~20 minutes, output will appear here: https://ci.appveyor.com/project/Umbraco/umbraco-cms-hs8dx/build/2811/artifacts
@matt I know I keep rejecting you (sorry!) but I didn't have time to dive into what your MSBuild stuff is doing exactly. I've created U4-7899 and maybe maybe I'll get a chance to look at it for the final release!
Backwards Compatible: True
Due in version:
Sprint: Sprint 8