U4-3458 - A few Issues with the new tab changes (tab drop down)

Created by Shannon Deminick 07 Nov 2013, 22:27:23 Updated by Per Ploug 13 Nov 2013, 12:59:29

There's a few issues with the new tab drop down changes:

  • Once you select a tab from the drop down, it remains highlighted (in black), so if you were to click on all of them, they will all remain black no matter which tab you are on. And once you click on one and navigate away from it, you can never navigate back.
  • It's minor, but the line styling drops down by a pixel: http://screencast.com/t/H0qlJMvXUaP
  • The bigger issue is tab validation - Currently there's JS errors because of the val-tab directive (see below), but the bigger problem is that there is no longer any tab level validation indication. With this new drop down change it will mean that if any of the tabs in the drop downs have properties with validation errors, the drop down will need to be highlighted and then the single tab that contains the error will need to be highlighted.

My advise is to revert the tabs and make this change for 7.1 - seems like a large change so late in the game.

Current JS errors occur here:

function valTab() { return { require: "^form", restrict: "A", link: function (scope, element, attr, formCtrl) { //ERROR HAPPENS HERE: var tabId = "tab" + scope.tab.id;

TypeError: Cannot read property 'id' of undefined at link (http://localhost:7000/umbraco/js/umbraco.directives.js:2570:42) at k (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:44:444) at e (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:40:139) at http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:39:205 at http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:162:213 at Object.fn (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:90:12) at Object.$get.e.$digest (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:90:356) at Object.$get.e.$apply (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:92:431) at j (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:101:80) at r (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:104:449)

  • angular.min.js:63 TypeError: Cannot read property 'id' of undefined at link (http://localhost:7000/umbraco/js/umbraco.directives.js:2570:42) at k (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:44:444) at e (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:40:139) at http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:39:205 at http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:162:213 at Object.fn (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:90:12) at Object.$get.e.$digest (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:90:356) at Object.$get.e.$apply (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:92:431) at j (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:101:80) at r (http://localhost:7000/umbraco/lib/angular/1.1.5/angular.min.js:104:449)
  • Comments

    Per Ploug 13 Nov 2013, 12:47:11

    agree, this is bigger implications that orginally predicted, lets set it as a high priority for 7.1


  • Priority: Normal

    Type: Bug

    State: Fixed

    Assignee: Per Ploug

    Difficulty: Normal

    Category:

    Backwards Compatible: True

    Fix Submitted:

    Affected versions: 7.0.0

    Due in version: 7.0.0

    Sprint:

    Story Points:

    Cycle: