U4-3562 - Cannot preview when no template is assigned

Created by Adam Prendergast 18 Nov 2013, 11:29:29 Updated by Brian Lacy 07 Jun 2016, 18:50:15

Relates to: U4-8530

Relates to: U4-2793

Relates to: U4-3631

The new release has a new feature to disable the preview button when no Umbraco template is used.

https://github.com/umbraco/Umbraco-CMS/commit/b11932240ca1a25a6f405f9afd6c0fe188f713fb

We have some sites that use custom templates in a directory structure that is not flat. Because of this the upgrade has disabled our preview functionality.

One possible solution could be introduce a config switch to re-enable the preview button for custom templates.

Let us know your thoughts and we can submit a pull request if required.

Comments

Adam Prendergast 19 Nov 2013, 17:58:33

Just to explain why I have escalated the bug.

We are using Umbraco primarily as a data source and are breaking out into custom views as soon as we have the RenderModel from Umbraco.

We also have preview working in this way with earlier releases (6.1.3) and the issue now is that the preview button is hidden when no Umbraco template is assigned.

This is preventing us from upgrading Umbraco in it's current state.


Jeremy Pyne 09 Sep 2014, 03:14:04

Can't you just assign an empty template? We actually use some template redirection but we do it in the templates themselves. You should get the same result though if you just assign a empty template in umbraco then override it in your controller/code.


Shannon Deminick 21 Jan 2015, 21:57:42

This also prevents previewing items that may have a hijacked route that are in charge of rendering their own templates (i.e. http://our.umbraco.org/projects/starter-kits/articulate/discussions/60562-Preview-Articulate-blog-post?p=0#comment205553)


Shannon Deminick 17 Mar 2015, 08:31:23

The reality is that we cannot hide the preview button, there's a bunch of different ways in which a node can render and it's very difficult to determine if something has a hijacked route when it's not in that items current route. So we're just going to show the preview button always.


Brian Lacy 07 Jun 2016, 18:50:15

Couldn't you just add a flag to Document Types to allow the Preview button to be visible or hidden? Then it's up to the dev/implementor, who should know if it's "previewable" or not..

EDIT
This has been discussed more recently in the forum post here: https://our.umbraco.org/forum/contributing-to-umbraco-cms/77569-is-it-possible-to-get-the-old-feature-back-that-hides-preview-when-there-is-not-any-template-available

However, always showing the Preview button definitely doesn't work for me. See: http://issues.umbraco.org/issue/U4-8530


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.0.0, 7.1.0, 6.1.4, 6.1.5, 6.1.6, 7.0.1, 7.0.2, 7.0.3, 7.0.4, 7.1.1, 7.2.0, 7.1.2, 7.1.3, 7.1.4, 7.1.5, 7.1.6, 7.1.7, 7.1.8, 7.1.9, 7.2.1

Due in version: 7.3.0, 7.2.3

Sprint:

Story Points:

Cycle: