U4-3653 - Bottom "Action" links inaccessible

Created by Matt Brailsford 21 Nov 2013, 19:41:20 Updated by Matt Brailsford 09 Dec 2013, 14:22:07

When using the "Action" dropdown when editing a content node, items at the bottom become inaccessible if the menu is too long (the popout version has a scrollbar, so you can get to them there, but we should probably be able to access everything from both).

1 Attachments

Comments

Per Ploug 09 Dec 2013, 13:36:59

This doesnt look right, the padding on this links does not look like this by default, could you check in the dev tools console to see what part of the umbraco.css file it gets this padding from?

In my version, the menu takes up about 500px in height, so it will never be an issue that it goes outside the screen


Matt Brailsford 09 Dec 2013, 13:48:34

It looks to be:

body.touch .umb-actions a

This might be a chrome specific thing, as I have run into issues on other sites I've built where Chrome has incorrectly identified itself as being touch enabled (I'm assuming the touch class should only get added if it's on a device).

I'm running on Chrome v31.0.1650.63 m, if that makes a difference.

Matt


Per Ploug 09 Dec 2013, 13:52:46

Yeah it should only identify as touch if it actually implements one of the touch-specific apis in the DOM - got any extensions installed that might make it return a false positive?

This is the test we run against the browser: var touchDevice = ("ontouchstart" in window || window.touch || window.navigator.msMaxTouchPoints === 5 || window.DocumentTouch && document instanceof DocumentTouch);


Per Ploug 09 Dec 2013, 13:53:41

Running the exact same chrome version here


Matt Brailsford 09 Dec 2013, 13:59:17

Strange. Nothing extra installed, so can't see why it would be returning false positive. Anyone else able to vouch it works as expected in Chrome so we can narrow it down to just being my machine?


Per Ploug 09 Dec 2013, 14:01:23

got a digitizer? think it might be Windows 8 that incorrectly tells chrome its a touch device due to the multi-touch trackpad..


Per Ploug 09 Dec 2013, 14:11:00

Fixed it, changed the touch detection so it doesnt use touch apis that chrome reports wrong on win 8


Matt Brailsford 09 Dec 2013, 14:13:41

Great stuff! I'm using a MBP, so think you might be right that Win 8 is trying to say it supports touch events. Out of interest, what was your code fix?


Per Ploug 09 Dec 2013, 14:19:36

There is no reliable way to detect touch in any browsers atm, lots of false positives. So replaced with the a slightly dumber agent string matching, which captures android, ios, blackberry and surface, so should be alright.


Matt Brailsford 09 Dec 2013, 14:22:07

Ahh, cool. Top work.


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.0.0

Due in version: 7.0.1

Sprint:

Story Points:

Cycle: