U4-3686 - Umbraco 7 - Rich Text Editor and Macro Issues

Created by Ahmed Abdul Moniem 25 Nov 2013, 04:24:30 Updated by Shannon Deminick 09 Dec 2013, 22:34:24

Insert Macro Issue: 1 - I have added some source code from the source code window of the RTE 2 - then after that I reverted back to wyswyg window and after the source was inserted I have added a macro using insert macro option after the source I have inserted and clicked save and publish 3 - suddenly all the text and source has been cleared but only the macro remains.

Render in RTE Issue: 1 - I created a macro and ticked the option of "Render in RTE" 2 - whenever I tried to add this macro to any RTE and clicked save and published it get duplicated (the html)

Comments

Per Ploug 04 Dec 2013, 09:26:05

I cant replicate either of these, the first one I would suspect the editor accidentally marks all content before inserting macro, but the other one I can replicate with macros rendering various html.

Any more details on browser, what parameters on the macro, does the macro actually render in the RTE, what type of macro?


Ahmed Abdul Moniem 04 Dec 2013, 09:33:59

For the Insert Macro Issue:

1 - Browser = Chrome latest version 2 - The macro parameters were none 3 - The macro render in RTE option is disabled so it is not rendering in the RTE 4 - macro type = .NET user control

For the second issue it is same as above


Henrik Andersen 04 Dec 2013, 09:38:25

I've created a macro with MVC Partial view.

@using System.Linq.Dynamic @inherits Umbraco.Web.Macros.PartialViewMacroPage

@Model.MacroParameters["title"]

@Model.MacroParameters["content"]
{code}

which renders fine in the editor. When hitting save and publish the content of the macro gets duplicated.


Ahmed Abdul Moniem 04 Dec 2013, 09:39:30

The same issue of Henrik with .Net Controls


Shannon Deminick 06 Dec 2013, 01:39:53

Yeah something strange is going on :( Had tested this quite a lot, maybe something has accidentally changed, will fix .


Shannon Deminick 06 Dec 2013, 04:08:08

This is pretty much fixed now in 2eb5c088258fd0ff1c4cb975da476583ce7208a8, It's all working, just need to do a bit more testing.


Henrik Andersen 09 Dec 2013, 09:42:56

I've just pulled the code from github last night, and build the umbraco.MacroEngines.dll in my project. Im still getting the duplicate content error. Am i missing some other .dll?


Shannon Deminick 09 Dec 2013, 22:34:24

The umbraco.MacroEngine's is not responsible for this - that assembly is purely for the legacy razor macros - in fact nearly every class in that assembly is obsolete.

Try running from the latest nightly of 7.0.1 : http://nightly.umbraco.org/umbraco%207.0.1/ You'll need to replace all files in ~/bin ~/umbraco ~/umbraco_client


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.0.0

Due in version: 7.0.1

Sprint:

Story Points:

Cycle: