Click here to create a new issue on GitHub

U4-4045 - The "Empty" partial view snippet should have @inherits

Created by Douglas Robar 14 Jan 2014, 11:37:19 Updated by Sebastiaan Janssen 15 Jan 2014, 20:02:36

v7.0.1 Create a new partial view and select the 'empty' snippet. The file is 100% empty.

It should have the following line at the top: @inherits Umbraco.Web.Mvc.UmbracoTemplatePage

Comments

Sebastiaan Janssen 14 Jan 2014, 12:50:06

Oversight on my part, fixed now in rev 5c55d6a6e3ad22aafe7d989fd40a7a6f699d8610
Shannon Deminick 14 Jan 2014, 23:39:10

This would appear to be an issue with 6.x as well...
Douglas Robar 15 Jan 2014, 10:13:03

This is not the correct fix.

All Settings>PartialView snippets have this at the top: @inherits Umbraco.Web.Mvc.UmbracoTemplatePage

The fix has done two things:

  1. The dialog has changed label from "Choose snippet" to "Choose template". It should be 'snippet' as discussed in U4-2737. This reversion from 'snippet' to 'template' appears in the Create dialogs for Partial Views, Scripting Files, and Partial View Macro Files (and maybe others I didn't think to check)

  2. The 'Empty' snippet has the wrong @inherits (using .PartialViewMacroPage instead)
Sebastiaan Janssen 15 Jan 2014, 20:02:36

  1. Eh.. Well it definitely didn't happen with this commit, not sure how it got reverted. :/

  2. Well this is embarrassing.. Updated again (99e91a1053d9bc249efd27d980a0ea35f4eecd77 for 6.2.0 and 168abddacfd7cfcb243490650b54f32a6bf25129 for 7.0.2) - fixing both issues.

Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 6.1.0, 7.0.0, 6.1.1, 6.1.2, 6.1.3, 6.1.4, 6.1.5, 6.1.6, 7.0.1

Due in version: 6.2.0, 7.0.2

Sprint:

Story Points:

Cycle: