U4-4154 - convert existing property data from XML to JSON during upgrade v6 - 7

Created by Martin Griffiths 28 Jan 2014, 14:58:44 Updated by Shannon Deminick 24 Mar 2014, 07:44:35

Relates to: U4-3446

I dont know whether to file this as a bug or a feature. But either way, users should not be left with no alternative but to dump their old related links datatype and re-create it and thereby losing data.

I've also noticed that the datatype fails miserably when it contains XML data! Which is hardly surprising when Umbraco 7 is expecting to see JSON.

Can this be handled in the installer as part of a 6 to 7 upgrade?

Comments

Shannon Deminick 29 Jan 2014, 00:30:19

This is part of the upgrade, there's a migration:

Umbraco.Core.Persistence.Migrations.Upgrades.TargetVersionSeven.UpdateRelatedLinksData

Perhaps it's not working for you because your other upgrades are failing and it's not getting to this point.


Martin Griffiths 29 Jan 2014, 09:23:15

Hi Shannon

After I tweaked the DB schema I did manage to get the installer to complete, but no sign of any converted datatypes.


Shannon Deminick 10 Feb 2014, 00:07:58

This should def be executing, I'm wondering if its the process you are going through that is causing it not to execute based on the version the upgrade is targetting. Not sure, I'll double check to make sure this script is executing (last time I looked it was).


Shannon Deminick 20 Mar 2014, 04:07:14

Just gonna test this again but I'm 99% sure this is working.


Shannon Deminick 20 Mar 2014, 05:45:18

I have verified that this does in fact update the data in the property table, however, it does not update the data in the xml table. The work around is that you'd have to re-publish each item with related links. I'm looking into ways to fix this.


Shannon Deminick 20 Mar 2014, 05:50:40

You'll need to execute this after upgrading:

/Umbraco/dialogs/republish.aspx?xml=true


Shannon Deminick 20 Mar 2014, 06:34:43

I've also fixed this so that it targets all data types with the related links property editor, before it was only targeting the data type that umbraco ships with.


Shannon Deminick 20 Mar 2014, 06:40:38

I'll update this before 7.1 release to ensure that the umbraco xml table is updated correctly without having to manually rebuild all of the xml.


Martin Griffiths 20 Mar 2014, 09:24:56

Thanks for your work on this Shannon :-)


Shannon Deminick 24 Mar 2014, 07:44:29

This is all done now, the xml structures will be updated and so will the xml file during upgrade. Note that this fix still only targets v7.0, if you are already working with a version greater than 7 and your data did not upgrade then you can just use the workaround described above and visit this URL:

/Umbraco/dialogs/republish.aspx?xml=true


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.0.0, 7.0.1, 7.0.2

Due in version: 7.1.0

Sprint:

Story Points:

Cycle: