We have moved to GitHub Issues
Created by Lee Kelleher 12 Mar 2014, 18:00:59 Updated by Rachel Ann 27 Nov 2017, 20:26:41Tags: PR
Relates to: U4-10718
With the Textbox Multiple property editor being able to define the height/rows.
Being able to define the height of a textarea would give a content-editor an indication of how much text is intended.
Also would be nice to be able to define max characters allowed. Yes yes I know that there is a property editor for this in uComponents but I really feel that it should be in the core instead of having to setup another property editor to be able to do this when it's a matter of adding some configuration instead :)
+1 character limit (in Core; without uComponents)
Agree. CharLimit option in the core would be GREAT!
I'll try and make a PR during the Easter break. Based on my package http://our.umbraco.org//projects/backoffice-extensions/kraftvaerkmaxlength just added to default textstring and multiline text.
Made a pull request on this issue https://github.com/umbraco/Umbraco-CMS/pull/355
Closing issue due to inactivity - see blog post for details https://umbraco.com/blog/issue-tracker-cleanup/
Still valid and PR might be simple enough to merge into future releases. Thanks for considering!
Thanks @madjor5 for your PR - so sorry we took such a long time to get to this. Code all read fine & been tested & due in 7.6.5
@warren.buckley I think it would be better to add the character limit as a directive/component, so it is reusable e.g. on textstring property editor or in any packages :) There is an alternative character limit package here: https://our.umbraco.org/projects/backoffice-extensions/input-character-limit/ https://our.umbraco.org/projects/backoffice-extensions/char-limit-74/
I have also thought about having the option to limit by words. Something like this might be useful: https://our.umbraco.org/projects/backoffice-extensions/text-count/
And the option to enable word/character count without setting a limit. https://github.com/markadrake/Umbraco-Property-Editors
Hi @Bjarne.Fyrstenborg they are all very valid options.
As my goal yesterday was to go through old PRs that we had open. To reply, review or close them. As this was the oldest PR, I tested it with the code that was submitted at that time back in in 2015 & of course better ways may have come along in the meantime. But the code submitted work as described and worked, so hence it was merged in.
If you think it should be improved further & wish to do so then I suggest a new issue, feel free to link/refer back to this & PR to avoid confusion.
Thanks, Warren :)
Could this issue be reopened? While the character count has been addressed in 7.7, there is still no option to change the height of the Textbox Multiple property (the original ticket).
After reading the suggestions above, I created a new feature request, http://issues.umbraco.org/issue/U4-10718
Type: Feature (request)
Backwards Compatible: True
Fix Submitted: Pull request
Affected versions: 7.6.3
Due in version: 7.6.5