We have moved to GitHub Issues
Created by Lee Kelleher 28 Mar 2014, 16:09:16 Updated by Niels Hartvig 02 Apr 2014, 09:54:41
I suspect this is an edge-case, but here goes...
I have a website logo that has a white foreground colour and a transparent background. When we select the image with the Media Picker, the preview is on-top of a white background, so we can't see the logo preview.
Suggested solution is to have a CSS background-image on the
<img> tag itself, like so:
I can submit a pull-request for this.
(Not sure how you embed images into the post)
But.. :) Now the editor is going to think: hey, my image suddenly has a grey background, what did I do?
Argh! Totally open to solutions on this... as we've also got an image like this (see attached)
Other options to consider...
"Objects in picker may be different then they appear"
Chequered may be best yes, that is much easier to explain then a solid background and a lot of people are already familiar with that from photo editing tools.
I'll update my PR. https://github.com/umbraco/Umbraco-CMS/pull/340
How much time is left before v7.1 cut off?
Still intend to launch Thursday, so make sure to do it tomorrow or Wednesday morning-ish at latest. :)
OK, trivial (but important) questions:
In my working copy, I've created a new image called "checkered-background.png" and placed it at ".\src\Umbraco.Web.UI.Client\src\assets\img" - this way the reference in the LESS/CSS is relative.
I had considered dropping the image into ".\src\Umbraco.Web.UI\Umbraco\Images", but didn't want to just dump it there.
Current (WIP) view of the Media Picker preview.
.\src\Umbraco.Web.UI.Client\src\assets\img is perfect.
No preferred filename convention that I know off.
Maybe make the checkers larger as it's now kind of hard to see the logo, would be nice if it's still clear there's a checkered background but also the image on it is more visible. Would checkers twice the size work?
What happens if there's no transparent png/gif on it, will we still see the background while the actual image is loading?
I tried a larger chequered size (the default Photoshop one is 8x8px), but it looked worse. So I reduce it down to 4x4px, which looked better, but not great.
The chequered background image would display for all image thumbnail/previews - depending on loading/latency it would be visible for a brief time.
@leekelleher Alright, in that case: ship it! :-)
PR updated: https://github.com/umbraco/Umbraco-CMS/pull/340
Excellent, thanks Seb!
Love it! Great contribution!
Backwards Compatible: True
Fix Submitted: Pull request
Affected versions: 7.0.0, 7.0.4
Due in version: 7.1.0