U4-4556 - Why is "Alias" included in Umbraco core property editor aliases?

Created by Bjarne Fyrstenborg 30 Mar 2014, 15:45:16 Updated by Bjarne Fyrstenborg 30 Jul 2018, 07:47:17

Subtask of: U4-7997

I am wondering why the word "Alias" is included in the Umbracos core property aliases? The naming conversion doesn't seem consistency between the build-in/core property editors..

Some examples here: Approved Color: Umbraco.ColorPickerAlias Checkbox list: Umbraco.CheckBoxList Content Picker: Umbraco.ContentPickerAlias Date Picker: Umbraco.Date

Any reason why Approved Color property editor not has a alias of "Umbraco.ColorPicker" and Content Picker property editor a alias of "Umbraco.ContentPicker"?

Just wondering why "Alias" is included in some and not in others?

Comments

Sebastiaan Janssen 31 Mar 2014, 10:15:53

An oversight. Not something we can easily change now as people might be relying on those wrong aliases. Sorry, we'll have to live with it for a while, we'll update so both with work at some point.


Bjarne Fyrstenborg 03 Apr 2016, 20:35:23

Maybe also rename the alias for Label property editor from "Umbraco.NoEdit" to "Umbraco.Label"


Bjarne Fyrstenborg 25 Jul 2018, 18:12:14

@nul800sebastiaan @Shandem has this "special" aliases with "Alias" in property editor alias been fixed in v8, otherwise it might be ideal to fix these :D


Shannon Deminick 30 Jul 2018, 05:10:57

@Bjarne.Fyrstenborg not quite sure if this has been updated in v8 yet but if you want to have a peek and update if necessary that'd be amazing :) Then we can write a db migration for the change too.


Bjarne Fyrstenborg 30 Jul 2018, 07:28:41

@Shandem nah, they seems to still exists in temp8 branch, so it would make sense to update these. :) https://github.com/umbraco/Umbraco-CMS/blob/59f9a64e816e40e52a64e1636f743da5effb98b6/src/Umbraco.Core/Constants-PropertyEditors.cs#L37

Also should we then also update "Umbraco.ContentPicker2" to just "Umbraco.ContentPicker"? https://github.com/umbraco/Umbraco-CMS/blob/59f9a64e816e40e52a64e1636f743da5effb98b6/src/Umbraco.Core/Constants-PropertyEditors.cs#L52

And I wonder if we both need a "Umbraco.Date" and "Umbraco.DateTime"? I guess both of these are storing a DateTime and more a configuration if they should include time? https://github.com/umbraco/Umbraco-CMS/blob/59f9a64e816e40e52a64e1636f743da5effb98b6/src/Umbraco.Core/Constants-PropertyEditors.cs#L63


Bjarne Fyrstenborg 30 Jul 2018, 07:47:17

Sorry, when searching it search in the default branch. It does seem to be updated :D https://github.com/umbraco/Umbraco-CMS/blob/temp8/src/Umbraco.Core/Constants-PropertyEditors.cs#L30

Also picker aliases are without "2" :D

I think also I makes sense to rename "Umbraco.NoEdit" to "Umbraco.Label". https://github.com/umbraco/Umbraco-CMS/blob/temp8/src/Umbraco.Core/Constants-PropertyEditors.cs#L130

Is there a specific reason why we need two aliases for DateTime pickers? :) https://github.com/umbraco/Umbraco-CMS/blob/temp8/src/Umbraco.Core/Constants-PropertyEditors.cs#L37-L45


Priority: Minor

Type: Bug

State: Open

Assignee:

Difficulty: Very Easy

Category:

Backwards Compatible: False

Fix Submitted:

Affected versions: 7.1.0, 7.4.0

Due in version: 8.0.0

Sprint:

Story Points:

Cycle: