U4-4618 - Open PublishedContentModelFactory to public

Created by Stephan 04 Apr 2014, 11:44:48 Updated by Lars-Erik Aabech 20 May 2014, 13:47:27

PublishedContentModel has been public for sometime now but PublishedContentModelFactory and its associated resolver are still internal, which means it is not possible to use PublishedContentModel without re-building Core. PublishedContentModelFactory and related stuff should be public.

Comments

Lars-Erik Aabech 04 Apr 2014, 11:57:08

Might possibly be an idea to leave PublishedContentModelFactoryResolver empty and document how to set it to PublishedContentModelFactoryImpl. Dunno if someone might have a performance issue with it being active.
We don't, though.


doron uziel 20 May 2014, 06:16:13

From What I see in v 7.1x source PublishedContentModel is internal again. as far as I can tell all that is required is to make it public, which will enable developers inherit from this class, and this create a strongly typed custom model, (but I might be wrong). If so then this is an awsome feature.


Stephan 20 May 2014, 06:30:25

There's now a pull request against 7.1 (https://github.com/umbraco/Umbraco-CMS/pull/385) where we discuss some implementation details. Renaming / refactoring some classes etc. We're almost there.


doron uziel 20 May 2014, 06:41:59

Thanks for the very quick response. Eagerly awaiting this.


Stephan 20 May 2014, 13:44:25

Merged the PR.


Lars-Erik Aabech 20 May 2014, 13:47:27

yay! [clicking invisible like button]


Priority: Normal

Type: Feature (request)

State: Fixed

Assignee: Stephan

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.1.4

Sprint:

Story Points:

Cycle: