U4-471 - Umbraco unique naming issue

Created by Sebastiaan Janssen 19 Aug 2012, 14:53:07 Updated by Sebastiaan Janssen 30 Aug 2012, 09:26:52

Subtask of: U4-136

The ensureUniqueNaming setting (which is true by default) in config/umbracoSettings.config is supposed to prevent nodes with duplicate names being created under a parent. However it seems to have a bug:-

Create node named Page at least 3 times :- Page Page (1) Page (2)

Umbraco is making sure the nodes are unique by appending (x)

Delete any of the numbered nodes (apart from the last one) e.g. Page Page (2)

Create another node named Page Page Page (2) Page (1)

Still no issues at the point. However create another node named Page Page Page (2) Page (1) Page (2)

There now exists nodes with the same name (and url). The issue seems to be that if the nodes are out of sequence (this could be because a node has been deleted or the nodes sorted) then umbEnsureUniqueName Action Handler fails to rename the nodes correctly.

I've fixed the Action Handler and will issue a pull request once the fix has been tested.

''Originally created on CodePlex by [DougM|http://www.codeplex.com/site/users/view/DougM]'' on 10/21/2011 3:55:18 PM [Codeplex ID: 30553 - Codeplex Votes: 2]

Imported comments

''Comment by [tomnf|http://www.codeplex.com/site/users/view/tomnf] on 10/21/2011 4:59:21 PM:'' Confirmed, same issue here

''Comment by [DougM|http://www.codeplex.com/site/users/view/DougM] on 10/26/2011 11:02:39 PM:'' I've created a pull request with a fix for this issue.


Sebastiaan Janssen 30 Aug 2012, 09:26:04

Pull request http://umbraco.codeplex.com/SourceControl/network/forks/DougM/umb471/contribution/1605 accepted.

Priority: Normal

Type: Bug

State: Fixed


Difficulty: Normal


Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 4.8.0, 4.9.0

Due in version: 4.9.0


Story Points: