U4-4766 - UmbracoMembershipProvider.ChangePassword() is seal, what might be a breaking change?

Created by Dirk 26 Apr 2014, 22:39:08 Updated by Dirk 28 Apr 2014, 09:54:08

In version 6.1.6 a custom MembershipProvider could override the ChangePassword() method. In version 6.2.0 this method is seal. I think this is a breaking change.

Comments

Shannon Deminick 28 Apr 2014, 09:15:57

hrm, in that case will have to unseal a bunch of things which is unfortunate since there are newer and better methods to override to ensure data consistency, by overriding this it particular method it will bypass all of the underlying logic. To maintain compatibility though we'll have to unseal them, just not sure how to flag these methods to say they 'shouldnt' be overridden and instead use the newer methods like PerformChangePassword


Shannon Deminick 28 Apr 2014, 09:17:43

Have fixed that in 2f53698bc553c8db0827de1877f76e0e4a5bbbc1


Dirk 28 Apr 2014, 09:54:08

Yes, I understand the reason for sealing it. But I think especially ChangePassword is very likely overriden by custom membership providers. I suggest you mark the method (and the others a like) as obsolete at least with a hint at the new methods. Thus the line return base.ChangePassword(...) gives you the obsolete hint... But I have no other idea yet.


Priority: Normal

Type: Usability Problem

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 6.2.0, 7.1.2

Sprint:

Story Points:

Cycle: