U4-4876 - Framework folders in nuget pkg

Created by Morten Christensen 13 May 2014, 10:00:46 Updated by Shannon Deminick 26 Jun 2017, 05:41:32

Right now we don't use the framework folders in our nuget package UmbracoCms.Core. All assemblies are in the root of the lib folder. So there is no indication that certain assemblies requires that the VS project is or should be ASP.NET 4.5.

Installing the nuget packages in an Empty WebApplication with framework 4.0 selected results in the Umbraco assemblies not being copied to the bin folder (tested in VS2012). There is no indication that the framework is the problem, so it leaves the developer confused.

Comments

Sebastiaan Janssen 13 May 2014, 10:10:11

Aah, so that's the upgrade problem as well maybe? https://twitter.com/robertjf72/status/466109458683162624


Morten Christensen 13 May 2014, 10:38:43

I'm not sure. Sounds more like its related to the assets (yepnode / LazyLoad thing). But if the (new) assemblies were not copied to the bin folder it could be related I guess.


Sebastiaan Janssen 13 May 2014, 10:57:38

@sitereactor No but the problem here is that after Update-Package UmbracoCms and then building the website it doesn't overwrite the dlls in the bin folder


Morten Christensen 13 May 2014, 11:03:44

If it doesn't do it on an explicit Rebuild it might at least be worth checking the framework version chosen for the web application.


Sebastiaan Janssen 13 May 2014, 14:52:47

Well that wasn't it, same project with 7.1.3-Pre and a net45 framework folder still doesn't overwrite the files in bin. Project is set to .net 4.5 framework. Puzzled.


Sebastiaan Janssen 17 Oct 2014, 18:17:17

Just an update to my puzzlement.. this was because when you include the dlls in your VS project, NuGet refused to overwrite them which is why we in later NuGet releases deleted them from the bin folder just to make sure they would get copied back in during build.

Unfortunately... when I put everything in a .net 4.5 folder it does start a rollback asp.net MVC depends on Json.Net just like we do. So instead of showing a nice error saying: hey.. you need to use .net 4.5, it just shows: couldn't remove json.net due to a dependency. #SadTrombone

So.. unless we can fix that, putting stuff in a framework folder is not going to fix anything :-(


Shannon Deminick 26 Jun 2017, 05:41:32

Closing issue due to inactivity - see blog post for details https://umbraco.com/blog/issue-tracker-cleanup/


Priority: Normal

Type: Bug

State: Closed

Assignee: Sebastiaan Janssen

Difficulty: Normal

Category: Packages

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.1.2

Due in version:

Sprint:

Story Points:

Cycle: