U4-4997 - `trySkipIisCustomErrors` default value?

Created by Lee Kelleher 27 May 2014, 10:48:30 Updated by Lee Kelleher 27 May 2014, 11:37:31

This may be more of a question for @zpqrtbnk - but may prompt a further discussion.

Having just spend a couple of hours trying to understand why my custom IContentFinder were not working, I eventually stumbled on the trySkipIisCustomErrors switch in 'umbracoSettings.config'.

I can appreciate why this is set as false for backwards compatibility reasons, but I'm wondering if there is a way where we can flag this as a warning if the application is using a custom IContentFinder? (otherwise it comes down to guesswork for someone to figure this out)

... or to force set the option to true if a custom IContentFinder is being used?

Comments

Stephan 27 May 2014, 11:04:14

Not sure I get the relation with IContentFinder. Unless we're talking about 404? Normal IContentFinder should not be impacted by that setting.


Lee Kelleher 27 May 2014, 11:07:35

Yes - sorry for 404 errors.

I thought the IContentFinder had replaced the legacy INotFoundHandler? (Unless I'm mistaken)


Stephan 27 May 2014, 11:25:30

No you're right, IContentFinder has replaced the legacy INotFoundHandler of course. It's just that... when using an IContentFinder to "find" normal content, trySkipIisCustomErrors does not come into play. OTOH as soon as you use an IContentFinder as the last chance finder... it does.

I ''think'' it should be enabled by default... in the next "breaking" version (8) but for the time being... what would be appropriate: a big warning in the log if we're 404 and it is not set? Could do.

Question: legacy INotFoundHandler should be impacted as well. Not the case?


Lee Kelleher 27 May 2014, 11:30:56

+1 A warning in the log would be suffice. (At least it gives a pointer on where to configure the option.)

I haven't used INotFoundHandler for a while (at least not since the trySkipIisCustomErrors option was introduced).


Stephan 27 May 2014, 11:32:47

Guess you would see the same issue with INotFoundHandler. OK, point taken, will add a warning when I get time.


Lee Kelleher 27 May 2014, 11:37:31

Thanks @zpqrtbnk, much appreciated!


Priority: Normal

Type: Meta Issue

State: Open

Assignee: Stephan

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version:

Sprint:

Story Points:

Cycle: