U4-5154 - MNTP breaks after upgrading v6 to v7 - prevalues issue

Created by Pavel Gurecki 27 Jun 2014, 07:33:37 Updated by Shannon Deminick 26 Jun 2017, 05:41:32

Hi,

after upgrading my 6.2.1 installation to 7.1.4 I've get YSOD when trying to open Multi Node Tree Picker based datatype in my backend (screenshot of YSOD attached).

The problem is caused by MNTP prevalues which are in different format in v6 and v7. I guess the problem is in https://github.com/umbraco/Umbraco-CMS/blob/7.1.4/src/Umbraco.Web/PropertyEditors/MultiNodeTreePickerPropertyEditor.cs : 70, it tries to get prevalue by "maxNumber" alias, which does not exist -> YSOD.

Simple fix could be checking if "maxNumber" key exists before trying to get value in MultiNodeTreePickerPropertyEditor.cs, this would remove YSOD.

Ideally, Umbraco install should detect upgrade from previous versions and transform old MNTP prevalues to new ones.

As temporary solution I use SQL script for removing all old MNTP prevalues and adding "maxNumber" prevalue row for all MNTP based datatypes. You can find script in related forum post: http://our.umbraco.org/forum/getting-started/installing-umbraco/54018-Upgrading-621-to-714-Failed-to-retrieve-data-for-data-type-error-for-MNTP

1 Attachments

Comments

Simon Dingley 20 Oct 2014, 07:20:49

I've also hit this on an upgrade from v6 to 7.1.6 (which needs adding to the affected versions list). Is there a less destructive solution to the problem which doesn't require blasting away all existing prevalues?


Pavel Gurecki 20 Oct 2014, 09:43:57

Currently I am not aware of other solution, but it is possible to write custom SQL script for converting old prevalue format to new one. Still some of options will be missing, as v7 MNTP lacks some of functionality we had in v6.


Simon Dingley 20 Oct 2014, 09:50:43

Thanks Pavel, thinking about this some more I think it would be far quicker to recreate the required prevalues vs finding or developing a solution to perform a conversion. Hopefully in the near future this will be handled in the upgrade process.


Shannon Deminick 26 Jun 2017, 05:41:32

Closing issue due to inactivity - see blog post for details https://umbraco.com/blog/issue-tracker-cleanup/


Priority: Normal

Type: Bug

State: Closed

Assignee:

Difficulty: Normal

Category: Installation

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.0.0, 7.1.0, 7.0.1, 7.0.2, 7.0.3, 7.0.4, 7.1.1, 7.1.2, 7.1.3, 7.1.4

Due in version:

Sprint:

Story Points:

Cycle: