U4-5167 - Exception When Searching Backoffice Content Using Quoted Term

Created by Nicholas Westby 01 Jul 2014, 16:36:44 Updated by Shannon Deminick 23 Jul 2014, 15:59:35

Is duplicated by: U4-5175

Relates to: U4-5194

Relates to: U4-5021

Relates to: U4-5048

If I search for "test" (with quotes), I get an exception message with no exception details and no stack trace and nothing in the UmbracoTaceLog.txt (see attached screenshot).

1 Attachments

Comments

Asbjørn Riis-Knudsen 18 Jul 2014, 15:49:06

I have made a pull request with a fix for this issue (and issue U4-5194): https://github.com/umbraco/Umbraco-CMS/pull/426


Shannon Deminick 22 Jul 2014, 22:27:23

I'll look at escaping these things correctly but for now this is great. Cheers!


Asbjørn Riis-Knudsen 23 Jul 2014, 04:56:16

Wouldn't escaping them stop the quotes from having any effect? Wouldn't they just become part of what you're searching for rather than a modifier affecting how you're searching? At least, that is why I chose this approach.


Shannon Deminick 23 Jul 2014, 15:41:44

It's now checking if the string is surrounded by quotes, if that is the case then it will be an exact match. The inner string will be escaped using Lucene's Escape method so that any invalid chars do not throw exceptions - and this will become part of the search.


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.0.4, 7.1.4

Due in version: 7.1.5

Sprint:

Story Points:

Cycle: