U4-5180 - 7.1.4 - publish/save notification email - highlighting is incorrect

Created by Dave Whiteford 03 Jul 2014, 12:48:43 Updated by Shannon Deminick 11 Aug 2015, 09:52:37

Relates to: U4-4060

Although email notifications are being sent - the highlighting (green for new, red for deleted) is incorrect.

Emails always report changes based on the FIRST incarnation of the page. So if I have a page that originally had just "hello" on it which has since been changed to have lots of content on it and I add a single character to the content it reports the ENTIRE page as being green (new content).

This continues to be the case despite what changes are made - the highlighting always refers to the first incarnation of the page.

This is causing issues for our clients who have strict publishing approval requirements.

Comments

David Rabbich 10 Jul 2014, 12:18:25

I am a colleague of the original poster. This is not a bug and is actually caused by none of the content tree being set to publish so the diff goes from the initial unpublished (first created) state of the document.

Please close this issue.


Matt Lethargic 14 Jul 2014, 15:01:51

This is a bug. The NotificationService calls GetVersions

NotificationService, Line 72 _contentService.GetVersions(entity.Id).ToArray();

This gets the versions in version order, newest first

VersionableRepositoryBase, line 37 .OrderByDescending(x => x.VersionDate);

Then the NotificationService gets the olddoc version by counting the total versions - 2, so picking the old version from the last but one item.... the second oldest version and not the second youngest version... still with me?!

NotificationService, Line 201 int versionCount = (allVersions.Length > 1) ? (allVersions.Length - 2) : (allVersions.Length - 1); var oldDoc = _contentService.GetByVersion(allVersions[versionCount].Version);

To fix the NotificationService or ContentService will need to make sure of the order of versions before selecting the oldDoc as currently the list of versions is ordered backwards

This seems to exist back to 6.2.1


David Rabbich 15 Jul 2014, 08:11:43

Hi Matt,

Thanks for replying and identifying the issue. The manual publish that I initially thought had resolved the issue had only partially resolved it. It looks like this still needs fixing in the main release as you've pointed out.


Ashford Borough Council 05 Aug 2015, 11:29:04

We are in the process of migrating our council website to Umbraco, and our web editors are also keen to have the highlighting working correctly. We are on v7.2.5 and incorrect highlighting still appears to be an issue. Is this seriously going to be addressed soon as it's quite fundamental?


Claus Jensen 06 Aug 2015, 08:41:59

Pull request submitted: https://github.com/umbraco/Umbraco-CMS/pull/759


Priority: Major

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.2.0, 6.2.1, 7.1.4

Due in version: 7.3.0

Sprint:

Story Points:

Cycle: