U4-5222 - Rollback Feature fails to update the UI to show the rolled back content - requires refresh

Created by kieran 15 Jul 2014, 02:07:12 Updated by Murray Roke 01 Oct 2017, 20:48:40

Tags: Unscheduled

Is duplicated by: U4-7261

Subtask of: U4-9609

On a fresh install of 7.1.4 in MVC project Steps to recreate -Create Doc type with string -create content from that doc type -Add data to that string type -save and publish -change the content of the string type -save and publish -Use Action -> Roll-back -Select the previous version in the roll back drop down -Confirm roll back

expected result -data is restored to selected version

actual result -the roll back target is overwritten with current published version.

Comments

Ben Richardson 11 Nov 2014, 17:22:24

I have also experienced this issue in 7.1.4. I have tried in FF and Chrome and experienced the same issue. After choosing a version to roll back to and clicking Rollback a message is displayed: "Document has been rolled back" and there is a CTA to close the window.

After closing the window I would expect the content pane to refresh as I had the item selected prior to rolling back. But the pane is not refreshed and I see the content prior to rollback.

If you navigate away and go back to the page you can see that it has rolled back.

However if you just publish without navigating away the rollback fails as the old content is republished therefore undoing the rollback.


Jason Prothero 24 Feb 2015, 21:41:27

We have also experienced this. It rollsback but the UI doesn't update. If we refresh the page then the page is rolled back.


James Hamilton 09 Mar 2015, 15:42:17

Same issue on 7.2.1

The backend UI does not update. If you reload the browser you can see the changes.


Valerie Gibson 09 Mar 2015, 15:49:02

Clients use this feature a lot so it would be good to get this fixed.


Mihail Trifonov 24 Jun 2015, 18:54:35

Reproducible in 7.2.6 as well. A simple refresh of the current document (if it's the one being rolled back, but that's usually the case) should fix this.


Steve Morgan 25 Sep 2015, 11:47:04

This still seems to be an issue on the latest version. It needs to reload the page. Is this just a grid issue?


Dan Evans 05 May 2016, 12:15:18

Is this still an issue in 7.4.3?


Dallas Taylor 11 Jun 2016, 00:43:33

This is still an issue in 7.4.3. When you rollback the content doesn't update. It is easy to publish the existing version rather than the version you rolled back to.

Dallas


Eric Schrepel 02 Aug 2016, 22:58:27

Also can confirm it's an issue in 7.4.3. You can copy/paste text from the rollback HTML view (instead of Diff view) back into rich text fields to sort of "manually" rollback, but the feature isn't working as intended.


kensley lewis 10 Aug 2017, 18:21:14

Also can confirm its still an issue in 7.6.3


Murray Roke 17 Sep 2017, 21:53:50

Still an issue in 7.6.5 I would also suggest removing the 'current' version from the drop down list, rolling back to the current state makes no sense.

(bonus feature, remove or un-highlight versions with no changes)


Shannon Deminick 27 Sep 2017, 16:39:51

PR https://github.com/umbraco/Umbraco-CMS/pull/2224

This is complete:

  • remove the 'current' version from the list
  • updated the UI so that if you have the document loaded that you are rolling back it will refresh the editor so you will be shown the rolled back content
  • there was a small issue actually but it wasn't obvious. the rollback dialog is super old and still uses the old Document API which actually has an issue with it. It doesn't set the 'latest' document version the correct way so when filtering out the current version, there was some odd things happening


Sebastiaan Janssen 28 Sep 2017, 18:00:36

Works better now.

That code though.. shudder ;-)


Murray Roke 01 Oct 2017, 20:48:40

Thanks guys, you rock :-)


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.1.4, 7.1.8, 7.2.1, 7.2.6, 7.4.3, 7.5.2, 7.6.3, 7.6.5

Due in version: 7.7.2, 7.6.9

Sprint: Sprint 68

Story Points: 1

Cycle: