U4-5374 - Cleanup constructors on services/repositories

Created by Morten Christensen 20 Aug 2014, 14:11:00 Updated by Shannon Deminick 21 Jan 2015, 04:46:01

Subtask of: U4-5830

Right now the constructors on the services are a mess with regards to overloads. For some services you can actually do new MacroService and it does a poor mans DI on required dependencies like the RepositoryFactory and PetaPocoUnitOfWorkProvider. We should just get rid of additional overloads and only have the necessary ctor, which is "handled" through the ServiceContext.

Changing the services is non-breaking according to this http://our.umbraco.org/documentation/Development-Guidelines/breaking-changes but we don't want to make this kind of change in a patch release, so its scheduled for next minor release.

Comments

Shannon Deminick 12 Jan 2015, 22:50:50

I've also cleaned up all of the ctors on the repositories too.


Priority: Normal

Type: Task

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.3.0

Sprint:

Story Points:

Cycle: