U4-5385 - Thumbnail issue that was "fixed" in 7.1.5

Created by david whiteford 22 Aug 2014, 08:24:59 Updated by Sebastiaan Janssen 26 Aug 2014, 05:51:25

Relates to: U4-4636

Relates to: U4-4673

This isnt 100% fixed.

yes it creates the correct sizes now, however they are names like: "jellyfish_250x317.jpg" rather than "jellyfish_250_thumb.jpg" - as I believe it should be named - the current way of naming its useless as we would need to know exact dimensions rather than just the prevalue value!

Also, in the admin panel the prevalues are emptied when the Data Type is saved - meaning there is no reference as to what they were set as. And then removing one removes them all as they are all empty.

Comments

Sebastiaan Janssen 22 Aug 2014, 15:05:56

Commit made by '''Sebastiaan Janssen''' on ''2014-08-22T17:05:47+02:00'' https://github.com/umbraco/Umbraco-CMS/commit/3b618b475d1049dcf37ee944cd9fbca438a0ff9f

#U4-5385 fixed Due in version: 7.2.0


Sebastiaan Janssen 22 Aug 2014, 15:08:36

For now I'd suggest you use [ImageProcessor|http://imageprocessor.org/imageprocessor-web/resize.html] to resize your images, just adding ?width=500&height=500&mode=max to your image (for ex.: <img src="@myImage?width=300&height=300&mode=max" />) should give you the same result as setting the thumbnail prevalue on the upload datatype to 300.


david whiteford 22 Aug 2014, 15:18:36

Thank you very much Sebastian - just for reference if you add prevalues of 100 or 500 to the thumbnail values this then causes an duplicate item in the dictionary error (because 100 and 500 are pre-programmed into the dictionary).

I assume that the UI will also be fixed for 7.2.0? (Prevalues getting blanked out on publish)

Thanks again


Sebastiaan Janssen 22 Aug 2014, 16:33:18

@david.whiteford It will have to be that way, people who configure this with 100 and 500 will expect _100 and _500 in the URL, people who don't will expect _thumb and _big-thumb in their url.

U4-4673 is now also fixed yes.


Sebastiaan Janssen 25 Aug 2014, 13:19:23

Commit made by '''Sebastiaan Janssen''' on ''2014-08-25T14:32:14+02:00'' https://github.com/umbraco/Umbraco-CMS/commit/1ded2c9baffb30996d35a2486321735b661cab9a

#U4-5385 fixed Due in version: 7.1.6


Shannon Deminick 25 Aug 2014, 23:01:52

I'll fix the duplicate dictionary entry - so there's no error but the file names will be as sebastian suggests with _thumb and _big-thumb. We could probably just update the pre-value editor to not allow 100 or 500 as input with a validation message.


Shannon Deminick 25 Aug 2014, 23:17:49

Duplicate key issue fixed in: e9b137cde80d32dbe29cf87575569edae287be71 I didn't update the pre-value editor to not accept these values and the file names for these will still be _thumb and _big_thumb but at least you won't get an error. As sebastian notes, it's best to just use image processor for image sizing


Shannon Deminick 25 Aug 2014, 23:19:16

Doh! I didn't realize 7.1.6 was already out! Oh well, I'll put this into 7.2, not a big deal.


Sebastiaan Janssen 26 Aug 2014, 05:51:25

:) FWIW, I didn't actually see an error for the duplicate dictionary items, so I left it as is.. But if it showed an error somewhere turn it's nice it's fixed!


Priority: Normal

Type: Bug

State: Fixed

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.1.4, 7.1.5

Due in version: 7.1.6

Sprint:

Story Points:

Cycle: