U4-5564 - GetCurrentServerUmbracoBaseUrl Ignores umbracoUseSSL

Created by Brian Powell 30 Sep 2014, 16:25:07 Updated by Arjan Hoogervorst 28 Nov 2014, 10:36:04

Umbraco.Core.Sync.ServerEnvironmentHelper.GetCurrentServerUmbracoBaseUrl() always returns a HTTP URL for /umbraco even if the umbracoUseSSL property is set in web.config. If umbracoUseSSL is true, it should be calling HTTPS for URLS under the Umbraco folder where this function's results get used.

ApplicationContext.Current.OriginalRequestUrl includes the port number, so just testing for Umbraco.Core.Configuration.GlobalSettings.UseSSL and prepending "https" instead of "http" isn't going to work.

Comments

Brian Powell 30 Sep 2014, 16:48:05

I've created a pull request at https://github.com/umbraco/Umbraco-CMS/pull/492 designed to address these problems in v7.2.0 with OriginalRequestUrl and GetCurrentServerUmbracoBaseUrl.


Arjan Hoogervorst 27 Nov 2014, 08:38:24

This bug is also still present in version 6.2.5.


Brian Powell 27 Nov 2014, 15:00:54

v6.2.5 is a separate branch in GitHub from 7.2.0. The changes from my above pull request will have to be made there as well to fix the 6.x line.


Arjan Hoogervorst 28 Nov 2014, 09:52:47

I'll create a pull request for the 6.2.5 branch.


Arjan Hoogervorst 28 Nov 2014, 10:36:04

https://github.com/umbraco/Umbraco-CMS/pull/569


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.1.6, 6.2.4

Due in version: 7.2.0

Sprint:

Story Points:

Cycle: