U4-5651 - 7.2: Installer broken, Lazyload.js missing

Created by Asbjørn Riis-Knudsen 16 Oct 2014, 07:37:24 Updated by Sebastiaan Janssen 10 Nov 2017, 07:50:47

Relates to: U4-4444

In 7.2, the installer is broken, as Lazyload.js is missing (it used to be in Umbraco/lib/lazyload). Lazyload.js is used in installer.loader.js.

Comments

Sebastiaan Janssen 16 Oct 2014, 07:49:03

Not missing in the latest build. If you still have this error, please provide more information.


Sebastiaan Janssen 16 Oct 2014, 07:50:03

Please also Google for Umbraco and LazyLoad as there have been some problems with it before, you might find a solution for your specific scenario.


Asbjørn Riis-Knudsen 16 Oct 2014, 07:56:07

If you have a look in this folder: https://github.com/umbraco/Umbraco-CMS/tree/ca58e8f98f96dc90a54eef317d908c0284218fda/src/Umbraco.Web.UI.Client/lib the lazyload folder is missing. It is there in 7.1.8. And the installer won't load, as Lazyload.js is referenced in this file (https://github.com/umbraco/Umbraco-CMS/blob/ca58e8f98f96dc90a54eef317d908c0284218fda/src/Umbraco.Web.UI.Client/src/install.loader.js). I just tried again cloning the latest commit from the 7.2.0 branch on Github. It does not work for me.


Sebastiaan Janssen 16 Oct 2014, 08:07:21

If you want to build from source, make sure to run build.bat to get all files in place. The problem is probably that the build for Belle hasn't ran yet, I suspect this is the first time you're trying to build v7 from source.


Asbjørn Riis-Knudsen 16 Oct 2014, 08:11:47

I've built v7 from source numerous times with no issues, 7.2.0 as recently as 10 days ago. This is a recent issue. And I do use build.bat. Once I copy in lazyload.js from an older build, the installer works just fine. But, if you cannot reproduce, it must be something with my system. I'll test on a few different systems and get back to you, if I find anything new.


Asbjørn Riis-Knudsen 16 Oct 2014, 08:12:52

Yes, I'm working a on pull request at the moment (https://github.com/umbraco/Umbraco-CMS/pull/504), that's why I'm building from source.


Sebastiaan Janssen 16 Oct 2014, 08:13:35

Noticed.. :) already removed my comment ;)


Asbjørn Riis-Knudsen 16 Oct 2014, 08:48:31

Sorry for being an idiot - my git got removed from the PATH, so it couldn't download lazyload. You were quite right :)It's working fine now.


Sebastiaan Janssen 19 Oct 2014, 15:00:10

Not your fault, the error was really hard to spot! I've updated the build.bat now so that it checks if git is in the path, if not it tries to find it in the default path and if that doesn't help it offers to install Git for you and puts it in the path, that should help for the next person!


Sebastiaan Janssen 19 Oct 2014, 15:01:25

Ps. Of course I've seen you do pull requests before (thanks!) so I knew you weren't building for the first time, but I only spotted your name waaay later so I didn't realize who I was talking to. ;-)


Asbjørn Riis-Knudsen 20 Oct 2014, 19:55:55

This has also fixed U4-4444, as far as I can see. I can now build with only VS2013 installed.


Sebastiaan Janssen 21 Oct 2014, 07:20:11

Yup!


Priority: Normal

Type: Bug

State: Can't Reproduce

Assignee:

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.0

Due in version:

Sprint:

Story Points:

Cycle: