We have moved to GitHub Issues
Created by Matt Brailsford 30 Oct 2014, 15:12:15 Updated by Sebastiaan Janssen 24 Oct 2017, 07:34:08Tags: Unscheduled PR
Subtask of: U4-9609
When configuring a row area, have the ability to set a max/min number of items in a cell.
Config supports it, but UI doesnt atm, is this a common scenario?
Min maybe not so much, but if you are producing a fixed grid layout, where you only one them to put 1 item per cell, then max is definitely handy.
I have just put in a PR to allow the user to set the max. I may have approached it differently than the config. https://github.com/umbraco/Umbraco-CMS/pull/651
Unfortunately not enough time to get this in to 7.2.3, have assigned to @Per.Ploug as he's more familiar with this part of the code
I need this and tried out the code in Peter's pull request. Works awesome! Looks like there's a merge conflict keeping it from the core. Just poking at this so it doesn't get forgotten. :)
I'd really like this as well!
@pploug I've submitted an updated pull request for this feature taking into account comments here and on the original one. I've also updated for the latest version of the grid.
Any updates on this ?
@pploug & @Shandem I've updated the pull request to the latest version of Umbraco with the hope it will encourage it to be included.
so, have tested both the original PR at https://github.com/umbraco/Umbraco-CMS/pull/651 and the revised PR at https://github.com/umbraco/Umbraco-CMS/pull/1506 - with the revised one, I can confirm that I can set a max on items, and then the "add content" option will disappear and one cannot drop content either.
it's been reported by many as working, and by my tests it works and it all seems clean enough. Proposing we merged.
OK, the PR we want to review is https://github.com/umbraco/Umbraco-CMS/pull/2247
Any chance of the minimum as well? It's actually a very common scenario (example: if you add a three column grid row, you don't want content in two columns but nothing in the third).
I can't think of a grid based site I wouldn't want this on!
Well I am currently going through a number of some quite old PRs, the idea being to get them merged and clean the queue -- not to spend time expanding their scope. The current PR does not include support for a minimum. We are going to merge it "as is" but I totally understand the need for minimum -- feel free to create another issue (and a PR!).
Great job guys, tested the feature and works as described, merging :).
Type: Feature (request)
Backwards Compatible: True
Fix Submitted: Pull request
Affected versions: 7.2.0
Due in version: 7.7.4
Sprint: Sprint 70
Story Points: 1