U4-5741 - [7.2] CodeMirror in RTE has issues in IE11

Created by Asbjørn Riis-Knudsen 02 Nov 2014, 21:39:17 Updated by Stephan 02 Sep 2015, 14:52:11

Relates to: U4-5781

Relates to: U4-6941

Relates to: U4-2604

Relates to: U4-5740

The first time you open Codemirror in the RTE, everything works fine. On the second try, it does not open and other buttons on the RTE stop working as well. There are various other issues as well: sometimes it won't close, instead inserting Unicode entities in the source code, sometimes it inserts empty paragraphs.

This is only happening in IE11, so there's probably some dodgy IE detection logic in TinyMCE or CodeMirror.

On a related note, should the CodeMirror version used for this be updated? It currently uses the one in Umbraco_Client/Codemirror, which is an ancient version (2.34). The TinyMCE 4 CodeMirror plugin only supports CodeMirror 3.13 or newer (http://www.avoid.org/codemirror-for-tinymce4/). I tested updating to the newest release of CodeMirror, but that doesn't resolve this issue.

Comments

Shannon Deminick 11 Nov 2014, 07:06:03

We'll have to wait to update the CM base library, it's too late in the release cycle to update js libs to new major versions.

I'll create a new task for 7.3: http://issues.umbraco.org/issue/U4-5781


Shannon Deminick 11 Nov 2014, 07:13:57

In IE, a JS error happens:

SCRIPT5022: IndexSizeError File: tinymce.min.js, Line: 5, Column: 14081


Shannon Deminick 11 Nov 2014, 07:17:26

We want to upgrade tinymce too but again, cannot do this for 7.2, will have to wait to 7.3 and might actually fix this, not sure, we'll need to test.

Maybe what we should is disable this by default for 7.2, the feature will be there if people want to enable it and hopefully we can fix this better in 7.3. I'll see if it's an easy fix, but I have a feeling it's not.


Per Ploug 17 Nov 2014, 14:46:37

Lets disable this by default, and look into it another time - those who care about this can turn it on and not use IE11


Shannon Deminick 17 Nov 2014, 22:17:13

Yup, it's been disabled already but is there for people to enable if they like


Eric Schrepel 14 Dec 2014, 21:19:50

I don't know if this is related but the RTE fields in our Umbraco installation broke after upgrading from 7.1.8 to 7.2 today. They only show source code, no toolbar, and aren't sized correctly. See my posting today at http://our.umbraco.org/forum/umbraco-7/using-umbraco-7/59764-Umbraco-72,-no-rich-text-editor-is-showing

Hopefully there's a quick n easy solution because everything else about the upgrade seemed to work well and we're excited to try the grid layout feature.


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.0

Due in version: 7.3.0

Sprint:

Story Points:

Cycle: