U4-5843 - Listview - empty result row doesn't have same number of columns as header

Created by Bjarne Fyrstenborg 19 Nov 2014, 19:58:57 Updated by Bjarne Fyrstenborg 02 Jan 2015, 14:17:40

Relates to: U4-6058

I Umbraco 7.2 beta2 and also the latest nightly build, when the listview return no results "There are no items show in the list." the row doesn't contain same number of columns as header.

The header has 6 columns, but the "empty row" use only colspan="5" resulting in missing border.

The markup should look like this:

... {code}

4 Attachments

Comments

Bjarne Fyrstenborg 24 Nov 2014, 23:29:16

Perhaps the colspan should be set dynamically as the listview is used multiple places - as default Data Types for content, media and members. But as you can configurate the columns the colspan might be lower or higher. There are as default for those 3 Data Types one column for checkbox, one column for Name, a column for each property (in this case three properties) and a column for search field.

However is there a reason for place the search field in the table header and not above the table? It would give more space for the content and placing the cursor in the search field wouldn't squeeze the content.


Bjarne Fyrstenborg 24 Nov 2014, 23:56:20

The screenshots of how it is now and if not having the search field in the table header. Maybe an idea might also be the truncate the Name after xx number of characters.


Shannon Deminick 29 Dec 2014, 22:11:15

If you can open a different ticket for the search field that would be good... I agree with moving the search bar but would need to check with @Per.Ploug


Shannon Deminick 02 Jan 2015, 00:52:14

PR is here: https://github.com/umbraco/Umbraco-CMS/pull/603


Bjarne Fyrstenborg 02 Jan 2015, 14:17:40

@Shandem if you haven't seen it, I created another issue for the search field. http://issues.umbraco.org/issue/U4-6058 ... in the pullrequest it use "+ 3" in colspan: 1 for the checkbox column, 1 for the name and 1 for the search field column. So would probably need to change it to "2" later, if you decide to move the search field out of the table header.


Priority: Normal

Type: Cosmetics

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted: Pull request

Affected versions: 7.2.0

Due in version: 7.2.2

Sprint:

Story Points:

Cycle: