U4-5981 - Umbraco 7.2 Text encoding when saving partial view template

Created by Tito 09 Dec 2014, 11:15:39 Updated by Sebastiaan Janssen 06 Jan 2015, 15:23:53

Is duplicated by: U4-5997

This is an issue that was solved on previous versions but it happens again on latest version 7.2 The old issue was this: http://issues.umbraco.org/issue/U4-2118 If i edit a partial view template and write some special characteres as "!", accents or "ñ" it shows as a wrong encoding. If is a variable it gives error rendering the page. ie: var año = DateTime.Now.Year; If create the template outside the Umbraco backoffice with a text editor it saves and renders ok.

Comments

Sebastiaan Janssen 18 Dec 2014, 12:56:56

Commit made by '''Sebastiaan Janssen''' on ''2014-12-18T13:56:50+01:00'' https://github.com/umbraco/Umbraco-CMS/commit/72004768cf965fe5a4fe1b61c59a56a37db67ac2

U4-5981 Umbraco 7.2 Text encoding when saving partial view template

#U4-5981 In Progress Assignee Shandem


Sebastiaan Janssen 18 Dec 2014, 12:57:54

Hey @Shandem I've updated the code that saves our files to add the BOM first. It works but I want to run it by you for reviewing the code before we close this issue.


Shannon Deminick 18 Dec 2014, 22:26:30

@sebastiaan there's definitely a nicer way to do that, i'll have a look.


Shannon Deminick 24 Dec 2014, 09:07:22

This change actually breaks uploading images and any other file since now some BOM bytes are added to those files too. The BOM will need to be added to the stream before being sent to the file system - so probably as part of the repository. Anyways, i'll fix it up.


Shannon Deminick 29 Dec 2014, 02:50:47

Fixed correctly in rev: 28a01d61a6c262318a8f778d5b6b09e5806f11b6


Sebastiaan Janssen 06 Jan 2015, 15:23:53

Thanks @Shandem ! Looks much better. :)


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions: 7.2.1

Due in version: 7.2.2

Sprint:

Story Points:

Cycle: