We have moved to GitHub Issues
Created by Lee M 11 Dec 2014, 15:59:05 Updated by Eric Wilkinson 08 Nov 2017, 15:56:40Tags: PR
Relates to: U4-6523
Relates to: U4-8290
Relates to: U4-10653
Relates to: U4-4383
Relates to: U4-5990
It would be nice if we could sort by a custom property in the list view, I realise that some property values are not orderable. But if you showed only properties that are of core types that can be ordered (i.e. Textstring, Numeric etc...) then it would make the listview even more flexible.
PR: https://github.com/umbraco/Umbraco-CMS/pull/711 (see comments on GitHub for details of approach taken)
it would be really great if this pull request could be included in 7.3
Its a bit odd there's been no movement on this for 7.3. Especially considering a fix has been submitted.
This one would be really useful for me in the core.
It would be. But we also have to make choices and this is a big one which unfortunately requires more time to test and look into than we can handle for 7.3.0. We'll reconsider for 7.4 which should come out by the end of the fall.
Thanks for the info. It's nice to know its at least on the horizon
hello - i can't see 7.4 scheduled on https://our.umbraco.org/contribute/progress Do you mean this could be due in 8? thanks
7.4 is there now
Just checked the 7.4 beta. Is this going to make it to final?
It's with a bit of disappointment that I see that this is still not scheduled to be included in any future release The current one in progress is 7.4.2, and I can't find any mention of this.
I've applied the submitted fix in 7.2.8, but the fix is not applicable any more in 7.4, because there's some big changes in the source code, meanwhile I'm stuck in 7.2.8 and can't move to any latest release, since this is a critical feature for me.
Looking forward for any updates regarding this.
Would love to see this soon as well. The listview is not really complete without this feature. It is kind of sad that the PR has sat without any action for over a year...
The votes for this one keep on rising!
would be cool if features were included in the next release depending on how many votes they have. This would be right up there for sure!
Whoop! Sprint 12
For the Core reviewers:
orderBySystemFieldparameter) overloads with zero optional parameters, this way the existing method will continue to work, there are not API usage breaks and we will not get ambiguous method call exceptions
PR is here: https://github.com/umbraco/Umbraco-CMS/pull/1216 for when we are ready for 7.5 - DO NOT PULL this in until after 7.4.3 is released, just marked this as Fixed.
@Shandem I can't review this as seems like it needs further attention from you, as Andy B has further SQL changes that may need looking at first before this can be reviewed over on the GitHub PR -https://github.com/umbraco/Umbraco-CMS/pull/1216#issuecomment-206732382
@warren.buckley go ahead and review mate, no need to worry about what Andy is mentioning there.
I've reviewed this one in both functionality and code and it looks good.
I added in a few fixes but apart from that it all looks good to merge in 7.5:
isSystemso sorting by this didn't work.
@Shandem: Marking this as fixed - do we have a way of keeping track of it so we remember to merge in 7.5?
Great testing!! I'll maybe change this branch name to just be 7.5 since i have some other stuff that can only be included in 7.5 too. Once 7.4.3 is out then we'll make dev-v7 7.5
@abutland any chance you tested this with SqlCe? Far as I can tell this will not work with SqlCe since it doesn't seem to support sub queries inside of Order By.
Ah... no, afraid not, SQL Express only. Sorry, I hadn't realised that restriction of CE.
Looks like you are correct though, see here: http://docs.telerik.com/data-access/developers-guide/database-specifics/database-specifics-sqlce-overview - "Microsoft SQL CE comes with a few restrictions in comparison with the other databases. The most important of them are ... SQL queries that use a subquery as a scalar expression in the WHERE clause", which is what we are doing here.
Yup, so the subquery and also some of the sql methods are not supported. I'm refactoring it to use an inner join on a temp table instead which might end up being better for performance anyways... not sure how I'll do the changes to the SQL methods yet. I've also improved performance because we don't need the sub sub sub query to get the latest version (that is already stored in a column in the db: 'newest')
Hi I've reported the issue separately (U4-8779) but this doesn't work for columns in the Members Listview.
Hi, is the List View order by custom property functionality intended to sort decimal doc type values? I am currently seeing incorrect sorting in 7.5.11? using both custom sort and sorting by column header click on decimal values.
Type: Feature (request)
Backwards Compatible: False
Fix Submitted: Pull request
Due in version: 7.5.0
Sprint: Sprint 13