U4-6005 - Please add a public constructor to InstallApiController

Created by Stephan Lonntorp 11 Dec 2014, 22:37:10 Updated by Shannon Deminick 02 Mar 2015, 06:03:21

Is duplicated by: U4-6311

The issue described in Doron's comment here: http://our.umbraco.org/forum/umbraco-7/using-umbraco-7/49719-Umbraco-710-upgrade-issue-with-dependency-injection is very much still an issue, when using DI and upgrading sites. I believe adding a public constructor to the controller would solve that issue.

Running an upgrade on a site with DI leaves the site in a partially upgraded state, as migrations aren't performed.

Comments

Martin Almström 23 Feb 2015, 12:34:46

Got this when upgrading from 7.2.1 to 7.2.2.


Sebastiaan Janssen 24 Feb 2015, 18:04:26

@Shandem Any reason there's not a public constructor on this class?


Shannon Deminick 26 Feb 2015, 01:40:16

no, i will make the change


Shannon Deminick 02 Mar 2015, 06:03:16

Seems very odd how this is working in the first place since both constructors are marked as 'protected'. Changed to public now: rev 100485f748199eee5251af6e96f40c0c58b3b846


Priority: Normal

Type: Bug

State: Fixed

Assignee: Shannon Deminick

Difficulty: Normal

Category:

Backwards Compatible: True

Fix Submitted:

Affected versions:

Due in version: 7.2.3

Sprint:

Story Points:

Cycle: